Bug 1357458
| Summary: | Missing spinner which indicates ajax requests | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Dmitry Misharov <dmisharo> |
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> |
| Status: | CLOSED WONTFIX | QA Contact: | Dmitry Misharov <dmisharo> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.5.0 | CC: | cpelland, dclarizi, dmisharo, hkataria, jhardy, jprause, mpovolny, obarenbo, simaishi |
| Target Milestone: | GA | Keywords: | Reopened |
| Target Release: | 5.5.6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | ui | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1337475 | Environment: | |
| Last Closed: | 2018-12-11 15:24:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1337475 | ||
| Bug Blocks: | |||
|
Comment 2
Harpreet Kataria
2016-07-25 18:56:08 UTC
Harpreet why do you close this bug? It was fixed in 5.6, but it's still presented in 5.5. That's why I cloned it. Dmitry, Flags on the BZ were confusing, i was under the impression that it was cloned to be backported to Darga. Re-opening this BZ, i will cherry-pick the fix on to 5.5.z ~Harpreet New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d562b4799109548c0f4dcc144d4db9a9ada5e408 commit d562b4799109548c0f4dcc144d4db9a9ada5e408 Author: Harpreet Kataria <hkataria> AuthorDate: Thu May 19 12:33:37 2016 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Aug 11 13:12:46 2016 -0400 Fixed code to start spinner when selecting values in drop down. - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call. - Added spec tests to verify fix https://bugzilla.redhat.com/show_bug.cgi?id=1337475 (cherry picked from commit 2a127d1) https://bugzilla.redhat.com/show_bug.cgi?id=1357458 app/assets/javascripts/miq_application.js | 9 ++++---- spec/javascripts/miq_application_spec.js | 38 +++++++++++++++++++++++++++++-- 2 files changed, 41 insertions(+), 6 deletions(-) New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c940a513612347e64eab8bca1034efd5684b30ba commit c940a513612347e64eab8bca1034efd5684b30ba Merge: efbd1bb d562b47 Author: Dan Clarizio <dclarizi> AuthorDate: Thu Aug 11 16:37:40 2016 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Thu Aug 11 16:37:40 2016 -0400 Merge branch '55z_pr_8823' into '5.5.z' Fixed code to start spinner when selecting values in drop down. - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call. - Added spec tests to verify fix https://bugzilla.redhat.com/show_bug.cgi?id=1337475 (cherry picked from commit 2a127d1) https://bugzilla.redhat.com/show_bug.cgi?id=1357458 @dclarizi please review, this is clean cherry-pick from https://github.com/ManageIQ/manageiq/pull/8823 See merge request !1026 app/assets/javascripts/miq_application.js | 9 ++++---- spec/javascripts/miq_application_spec.js | 38 +++++++++++++++++++++++++++++-- 2 files changed, 41 insertions(+), 6 deletions(-) |