Bug 1357458 - Missing spinner which indicates ajax requests
Summary: Missing spinner which indicates ajax requests
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.5.0
Hardware: All
OS: All
high
medium
Target Milestone: GA
: 5.5.6
Assignee: Harpreet Kataria
QA Contact: Dmitry Misharov
URL:
Whiteboard: ui
Depends On: 1337475
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-18 09:36 UTC by Dmitry Misharov
Modified: 2018-12-11 15:24 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1337475
Environment:
Last Closed: 2018-12-11 15:24:16 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 Harpreet Kataria 2016-07-25 18:56:08 UTC

*** This bug has been marked as a duplicate of bug 1337475 ***

Comment 3 Dmitry Misharov 2016-07-26 06:07:49 UTC
Harpreet why do you close this bug? It was fixed in 5.6, but it's still presented in 5.5. That's why I cloned it.

Comment 4 Harpreet Kataria 2016-07-27 14:41:20 UTC
Dmitry,

Flags on the BZ were confusing, i was under the impression that it was cloned to be backported to Darga. Re-opening this BZ, i will cherry-pick the fix on to 5.5.z

~Harpreet

Comment 8 CFME Bot 2016-08-11 20:41:59 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d562b4799109548c0f4dcc144d4db9a9ada5e408

commit d562b4799109548c0f4dcc144d4db9a9ada5e408
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu May 19 12:33:37 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Aug 11 13:12:46 2016 -0400

    Fixed code to start spinner when selecting values in drop down.
    
    - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call.
    - Added spec tests to verify fix
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1337475
    (cherry picked from commit 2a127d1)
    https://bugzilla.redhat.com/show_bug.cgi?id=1357458

 app/assets/javascripts/miq_application.js |  9 ++++----
 spec/javascripts/miq_application_spec.js  | 38 +++++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 6 deletions(-)

Comment 9 CFME Bot 2016-08-11 20:42:09 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c940a513612347e64eab8bca1034efd5684b30ba

commit c940a513612347e64eab8bca1034efd5684b30ba
Merge: efbd1bb d562b47
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Aug 11 16:37:40 2016 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Aug 11 16:37:40 2016 -0400

    Merge branch '55z_pr_8823' into '5.5.z'
    
    Fixed code to start spinner when selecting values in drop down.
    
    - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call.
    - Added spec tests to verify fix
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1337475
    (cherry picked from commit 2a127d1)
    https://bugzilla.redhat.com/show_bug.cgi?id=1357458
    
    @dclarizi please review, this is clean cherry-pick from https://github.com/ManageIQ/manageiq/pull/8823
    
    See merge request !1026

 app/assets/javascripts/miq_application.js |  9 ++++----
 spec/javascripts/miq_application_spec.js  | 38 +++++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 6 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.