Red Hat Bugzilla – Bug 1337475
Missing spinner which indicates ajax requests
Last modified: 2016-08-11 16:42:04 EDT
Description of problem: When user fills a form miqspinner is missing. Version-Release number of selected component (if applicable): 5.6.0.7-beta2.6.20160516171555_b1be31f How reproducible: Always Steps to Reproduce: 1. Navigate to Control->Explorer. 2. Expand Alerts accordion. 3. Add a new alert. 4. Try pick "Cluster / Deployment Role" from dropdown menu Actual results: There is no the spinner which indicates ajax request. Expected results: There is the spinner which indicates ajax request.
https://github.com/ManageIQ/manageiq/pull/8823
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/2a127d1beebd946f13b754184d25d5330efe8f6d commit 2a127d1beebd946f13b754184d25d5330efe8f6d Author: Harpreet Kataria <hkataria@redhat.com> AuthorDate: Thu May 19 12:33:37 2016 -0400 Commit: Harpreet Kataria <hkataria@redhat.com> CommitDate: Thu May 19 13:33:54 2016 -0400 Fixed code to start spinner when selecting values in drop down. - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call. - Added spec tests to verify fix https://bugzilla.redhat.com/show_bug.cgi?id=1337475 app/assets/javascripts/miq_application.js | 9 ++++---- spec/javascripts/miq_application_spec.js | 38 +++++++++++++++++++++++++++++-- 2 files changed, 41 insertions(+), 6 deletions(-)
*** Bug 1339240 has been marked as a duplicate of this bug. ***
Verified fixed in 5.6.0.8-rc1.20160524155303_f2a5a50.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348
*** Bug 1357458 has been marked as a duplicate of this bug. ***
New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d562b4799109548c0f4dcc144d4db9a9ada5e408 commit d562b4799109548c0f4dcc144d4db9a9ada5e408 Author: Harpreet Kataria <hkataria@redhat.com> AuthorDate: Thu May 19 12:33:37 2016 -0400 Commit: Harpreet Kataria <hkataria@redhat.com> CommitDate: Thu Aug 11 13:12:46 2016 -0400 Fixed code to start spinner when selecting values in drop down. - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call. - Added spec tests to verify fix https://bugzilla.redhat.com/show_bug.cgi?id=1337475 (cherry picked from commit 2a127d1) https://bugzilla.redhat.com/show_bug.cgi?id=1357458 app/assets/javascripts/miq_application.js | 9 ++++---- spec/javascripts/miq_application_spec.js | 38 +++++++++++++++++++++++++++++-- 2 files changed, 41 insertions(+), 6 deletions(-)
New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c940a513612347e64eab8bca1034efd5684b30ba commit c940a513612347e64eab8bca1034efd5684b30ba Merge: efbd1bb d562b47 Author: Dan Clarizio <dclarizi@redhat.com> AuthorDate: Thu Aug 11 16:37:40 2016 -0400 Commit: Dan Clarizio <dclarizi@redhat.com> CommitDate: Thu Aug 11 16:37:40 2016 -0400 Merge branch '55z_pr_8823' into '5.5.z' Fixed code to start spinner when selecting values in drop down. - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call. - Added spec tests to verify fix https://bugzilla.redhat.com/show_bug.cgi?id=1337475 (cherry picked from commit 2a127d1) https://bugzilla.redhat.com/show_bug.cgi?id=1357458 @dclarizi please review, this is clean cherry-pick from https://github.com/ManageIQ/manageiq/pull/8823 See merge request !1026 app/assets/javascripts/miq_application.js | 9 ++++---- spec/javascripts/miq_application_spec.js | 38 +++++++++++++++++++++++++++++-- 2 files changed, 41 insertions(+), 6 deletions(-)