Bug 1337475 - Missing spinner which indicates ajax requests
Summary: Missing spinner which indicates ajax requests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: All
OS: All
high
medium
Target Milestone: GA
: 5.6.0
Assignee: Harpreet Kataria
QA Contact: Dmitry Misharov
URL:
Whiteboard: ui
Depends On:
Blocks: 1357458
TreeView+ depends on / blocked
 
Reported: 2016-05-19 09:36 UTC by Dmitry Misharov
Modified: 2016-08-11 20:42 UTC (History)
7 users (show)

Fixed In Version: 5.6.0.8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1357458 (view as bug list)
Environment:
Last Closed: 2016-06-29 16:04:13 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Dmitry Misharov 2016-05-19 09:36:33 UTC
Description of problem:
When user fills a form miqspinner is missing.

Version-Release number of selected component (if applicable):
5.6.0.7-beta2.6.20160516171555_b1be31f 

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Control->Explorer.
2. Expand Alerts accordion.
3. Add a new alert.
4. Try pick "Cluster / Deployment Role" from dropdown menu

Actual results:
There is no the spinner which indicates ajax request.

Expected results:
There is the spinner which indicates ajax request.

Comment 2 Harpreet Kataria 2016-05-19 16:44:51 UTC
https://github.com/ManageIQ/manageiq/pull/8823

Comment 3 CFME Bot 2016-05-20 14:40:51 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2a127d1beebd946f13b754184d25d5330efe8f6d

commit 2a127d1beebd946f13b754184d25d5330efe8f6d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu May 19 12:33:37 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu May 19 13:33:54 2016 -0400

    Fixed code to start spinner when selecting values in drop down.
    
    - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call.
    - Added spec tests to verify fix
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1337475

 app/assets/javascripts/miq_application.js |  9 ++++----
 spec/javascripts/miq_application_spec.js  | 38 +++++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 6 deletions(-)

Comment 4 Harpreet Kataria 2016-05-24 13:40:51 UTC
*** Bug 1339240 has been marked as a duplicate of this bug. ***

Comment 5 Dmitry Misharov 2016-05-26 07:03:23 UTC
Verified fixed in 5.6.0.8-rc1.20160524155303_f2a5a50.

Comment 7 errata-xmlrpc 2016-06-29 16:04:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Comment 8 Harpreet Kataria 2016-07-25 18:56:08 UTC
*** Bug 1357458 has been marked as a duplicate of this bug. ***

Comment 9 CFME Bot 2016-08-11 20:41:55 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d562b4799109548c0f4dcc144d4db9a9ada5e408

commit d562b4799109548c0f4dcc144d4db9a9ada5e408
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu May 19 12:33:37 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Aug 11 13:12:46 2016 -0400

    Fixed code to start spinner when selecting values in drop down.
    
    - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call.
    - Added spec tests to verify fix
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1337475
    (cherry picked from commit 2a127d1)
    https://bugzilla.redhat.com/show_bug.cgi?id=1357458

 app/assets/javascripts/miq_application.js |  9 ++++----
 spec/javascripts/miq_application_spec.js  | 38 +++++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 6 deletions(-)

Comment 10 CFME Bot 2016-08-11 20:42:04 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c940a513612347e64eab8bca1034efd5684b30ba

commit c940a513612347e64eab8bca1034efd5684b30ba
Merge: efbd1bb d562b47
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Aug 11 16:37:40 2016 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Aug 11 16:37:40 2016 -0400

    Merge branch '55z_pr_8823' into '5.5.z'
    
    Fixed code to start spinner when selecting values in drop down.
    
    - Changed code to set options.beforeSend and options.complete using $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') only if $(this).attr('data-miq_sparkle_on') & $(this).attr('data-miq_sparkle_off') were set otherwise use the values that were sent with JS function call.
    - Added spec tests to verify fix
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1337475
    (cherry picked from commit 2a127d1)
    https://bugzilla.redhat.com/show_bug.cgi?id=1357458
    
    @dclarizi please review, this is clean cherry-pick from https://github.com/ManageIQ/manageiq/pull/8823
    
    See merge request !1026

 app/assets/javascripts/miq_application.js |  9 ++++----
 spec/javascripts/miq_application_spec.js  | 38 +++++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 6 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.