Bug 1360772
Summary: | pods are named 'container groups' in the policy explorer right cell | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Chris Pelland <cpelland> |
Component: | UI - OPS | Assignee: | Beni Paskin-Cherniavsky <cben> |
Status: | CLOSED ERRATA | QA Contact: | Dmitry Misharov <dmisharo> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 5.7.0 | CC: | cben, cpelland, dmisharo, fsimonce, hkataria, jhardy, jprause, mpovolny, mtayer, obarenbo |
Target Milestone: | GA | Keywords: | ZStream |
Target Release: | 5.6.1 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | container:ui:control | ||
Fixed In Version: | 5.6.1.2 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1359909 | Environment: | |
Last Closed: | 2016-08-18 18:00:11 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1359909 | ||
Bug Blocks: |
Comment 1
Federico Simoncelli
2016-08-08 08:47:41 UTC
https://github.com/ManageIQ/manageiq/pull/9347 Ready from my side, needs review/merge. (that's master. darga has small conflict => have a ready backport branch: https://github.com/ManageIQ/manageiq/compare/darga...cben:darga-policy-ui_lookup) Beni To make this as clear as possible[1] please, 1. submit a pr for darga (can be wip until master merges) 2. have that darga commit in one comment in this pr "Submitted downstream: pr" 3. The upstream pr already contains 9347 but It is with a lot of other text. It will help to have there "Submitted upstream: https://github.com/ManageIQ/manageiq/pull/9347" That will make it clear we are handling bz 1359909 with pr 9347. 4. any other issues mentioned in 1359909 you want to track can have new git hub issue/bz. [1] important especially when we want to merge things fast. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/40d3263a82282c26854eac34791f2678265ce83a commit 40d3263a82282c26854eac34791f2678265ce83a Author: Beni Cherniavsky-Paskin <cben> AuthorDate: Mon Aug 8 16:19:15 2016 +0300 Commit: Beni Cherniavsky-Paskin <cben> CommitDate: Mon Aug 8 16:19:15 2016 +0300 Fix multiple ui_lookup(:model => nonCamelized) Hopefully fixed all occurrences in MiqPolicyController. Enables some non-working translations, affects even English terminology ("Container Image -> Image" etc). https://bugzilla.redhat.com/show_bug.cgi?id=1359909 https://bugzilla.redhat.com/show_bug.cgi?id=1360772 app/controllers/miq_policy_controller.rb | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) Fixed and verified in 5.6.1.2.20160810181333_8ba817b. The right part of the policy explorer has the correct name. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-1634.html |