Bug 1364145

Summary: Forbid mixing QoS and non-QoS on the same NIC
Product: [oVirt] ovirt-engine Reporter: Yevgeny Zaspitsky <yzaspits>
Component: BLL.NetworkAssignee: Yevgeny Zaspitsky <yzaspits>
Status: CLOSED CURRENTRELEASE QA Contact: Meni Yakove <myakove>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0.0CC: bugs, danken, gklein, mburman, sbonazzo
Target Milestone: ovirt-4.0.2Flags: rule-engine: ovirt-4.0.z+
rule-engine: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+
Target Release: 4.0.2.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-17 14:44:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yevgeny Zaspitsky 2016-08-04 14:28:41 UTC 
Description of problem:
Defining a QoS on a non-VLAN network in fact defines a default QoS for all other networks on the same NIC with no QoS defined.
Thus it was decided to forbid defining such configuration in the engine side.

How reproducible:
100%

Expected results:
The problematic configuration wouldn't be possible.

Additional info:
Bug#1359484
Bug#1271094
Bug#1255474
Comment 1 Yevgeny Zaspitsky 2016-08-04 14:40:43 UTC 
We should consider re-opening Bug#1271094 as the solution of this bug reverts the solution of that bug.
Comment 2 Red Hat Bugzilla Rules Engine 2016-08-04 14:41:07 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 3 Red Hat Bugzilla Rules Engine 2016-08-04 14:41:40 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 4 Yevgeny Zaspitsky 2016-08-04 15:36:21 UTC 
VDSM configures a default QoS on a non-VLAN network, if a QoS is requested on some of the VLAN networks as max(defined ls). That is done in order to balance the traffic for all non-QoS networks.
This VDSM behavior makes the engine to report the non-VLAN network as out-of-sync, because it has the QoS that wasn't requested.

Configuring partial QoS weights doesn't make much sense to me, and makes the non-VLAN network to be out-of-sync, so that justifies expanding the scope of this change to "Forbid mixing QoS and non-QoS on the same NIC".
Comment 5 Michael Burman 2016-08-14 07:54:29 UTC 
Verified on - 4.0.2.6-0.1.el7ev