Bug 1364145 - Forbid mixing QoS and non-QoS on the same NIC
Summary: Forbid mixing QoS and non-QoS on the same NIC
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.2
: 4.0.2.6
Assignee: Yevgeny Zaspitsky
QA Contact: Meni Yakove
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-04 14:28 UTC by Yevgeny Zaspitsky
Modified: 2016-08-17 14:44 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-17 14:44:22 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.0.z+
rule-engine: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1255474 0 medium CLOSED [RFE][SCALE] traffic shaping on ovirtmgmt interface 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1271094 0 high CLOSED [Host QoS] - Updating second network with host QoS when it attached to host NIC with another network that is out-of-sync... 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1359484 0 low CLOSED [Host QoS] - Engine should take care and apply host QoS on all the networks attached to the same interface and sync them 2022-06-27 08:00:32 UTC
oVirt gerrit 61914 0 master MERGED Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" 2016-08-07 12:16:50 UTC
oVirt gerrit 61915 0 master MERGED Revert "engine: allow QoS and non-QoS networks to be attached to a nic" 2016-08-07 12:16:38 UTC
oVirt gerrit 62021 0 ovirt-engine-4.0 MERGED Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" 2016-08-07 20:10:32 UTC
oVirt gerrit 62022 0 ovirt-engine-4.0 MERGED Revert "engine: allow QoS and non-QoS networks to be attached to a nic" 2016-08-07 20:10:27 UTC
oVirt gerrit 62023 0 ovirt-engine-4.0.2 MERGED Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" 2016-08-08 07:17:05 UTC
oVirt gerrit 62024 0 ovirt-engine-4.0.2 MERGED Revert "engine: allow QoS and non-QoS networks to be attached to a nic" 2016-08-08 07:17:16 UTC

Internal Links: 1255474 1271094 1359484

Description Yevgeny Zaspitsky 2016-08-04 14:28:41 UTC
Description of problem:
Defining a QoS on a non-VLAN network in fact defines a default QoS for all other networks on the same NIC with no QoS defined.
Thus it was decided to forbid defining such configuration in the engine side.

How reproducible:
100%

Expected results:
The problematic configuration wouldn't be possible.

Additional info:
Bug#1359484
Bug#1271094
Bug#1255474

Comment 1 Yevgeny Zaspitsky 2016-08-04 14:40:43 UTC
We should consider re-opening Bug#1271094 as the solution of this bug reverts the solution of that bug.

Comment 2 Red Hat Bugzilla Rules Engine 2016-08-04 14:41:07 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 3 Red Hat Bugzilla Rules Engine 2016-08-04 14:41:40 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 4 Yevgeny Zaspitsky 2016-08-04 15:36:21 UTC
VDSM configures a default QoS on a non-VLAN network, if a QoS is requested on some of the VLAN networks as max(defined ls). That is done in order to balance the traffic for all non-QoS networks.
This VDSM behavior makes the engine to report the non-VLAN network as out-of-sync, because it has the QoS that wasn't requested.

Configuring partial QoS weights doesn't make much sense to me, and makes the non-VLAN network to be out-of-sync, so that justifies expanding the scope of this change to "Forbid mixing QoS and non-QoS on the same NIC".

Comment 5 Michael Burman 2016-08-14 07:54:29 UTC
Verified on - 4.0.2.6-0.1.el7ev


Note You need to log in before you can comment on or make changes to this bug.