Bug 1365736
| Summary: | Error message should be clear when connect to a spice guest with wrong password | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | zhoujunqin <juzhou> | ||||
| Component: | spice-gtk | Assignee: | Snir Sheriber <ssheribe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.3 | CC: | mxie, mzhan, pgrunt, rbalakri, rduda, ssheribe, tpelka, tzheng, xiaodwan | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | spice-gtk-0.33-4.el7 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-08-01 15:04:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
I agree that would be nice to improve the error message. Most likely handling connection failures in general would have to be reworked -> moving to 7.4 (just a comment: virt-viewer / remote-viewer doesn't have the issue in case of failure it asks again for the password. Maybe error handling can be improved in virt-manager) Hi Pavel, I meet another problem when reproduce this bug. could you help to check whether below problem could be fixed with this bug together? Description of problem: Wrong password can't be cleared automatically after clicking "ok" for authentication failed dialog for spice guest Version-Release number of selected component (if applicable): virt-manager-1.4.0-2.el7.noarch libvirt-2.0.0-10.el7_3.4.x86_64 qemu-kvm-rhev-2.6.0-28.el7_3.3 How reproducible: 100% Steps to Reproduce: 1. Prepare a spice guest with password setting in virt-manager 2. Open the guest console and type wrong password, will pop up error "Viewer authentication error: Authentication failed: password is required" 3. Click "ok" for Authentication failed dialog, but the wrong password can't be cleared automatically Actual results: As subject Expected results: Wrong password can be cleared automatically after clicking "ok" for authentication failed dialog for spice guest Additional info: 1.Wrong password can be cleared automatically after clicking "ok" for authentication failed dialog for VNC guest Hi, clearing the password input must be done in virt-manager, so not in this bug (In reply to Pavel Grunt from comment #4) > Hi, > > clearing the password input must be done in virt-manager, so not in this bug Thanks for your reply. have filed one to track this problem https://bugzilla.redhat.com/show_bug.cgi?id=1414296 possible fix: https://patchwork.freedesktop.org/series/20263/ (In reply to Snir Sheriber from comment #6) > possible fix: > https://patchwork.freedesktop.org/series/20263/ I'd like to remove the blank space between 'password' and '?' in "wrong password ?". (In reply to xiaodwan from comment #8) > (In reply to Snir Sheriber from comment #6) > > possible fix: > > https://patchwork.freedesktop.org/series/20263/ > > I'd like to remove the blank space between 'password' and '?' in "wrong > password ?". sure, np. (In reply to Snir Sheriber from comment #9) > (In reply to xiaodwan from comment #8) > > (In reply to Snir Sheriber from comment #6) > > > possible fix: > > > https://patchwork.freedesktop.org/series/20263/ > > > > I'd like to remove the blank space between 'password' and '?' in "wrong > > password ?". > > sure, np. Actually why there is '?' at all? It is no doubt that password is wrong in that case isn't it? Given https://bugzilla.redhat.com/show_bug.cgi?id=1365736#c9 moving to assigned (In reply to Radek Duda from comment #10) > (In reply to Snir Sheriber from comment #9) > > (In reply to xiaodwan from comment #8) > > > (In reply to Snir Sheriber from comment #6) > > > > possible fix: > > > > https://patchwork.freedesktop.org/series/20263/ > > > > > > I'd like to remove the blank space between 'password' and '?' in "wrong > > > password ?". > > > > sure, np. > > Actually why there is '?' at all? It is no doubt that password is wrong in > that case isn't it? Given > https://bugzilla.redhat.com/show_bug.cgi?id=1365736#c9 moving to assigned It will probably almost always show up because the password is wrong but theoretically it could happen for other reasons too (e.g. expire password ..) Fixed upstream since https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=366344f37bc756137b0c5009135088f4bf562b04 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:1849 |
Created attachment 1189469 [details] screenshot for step-4 Description of problem: Error message should be clear when connect to a spice guest with wrong password Version-Release number of selected component (if applicable): virt-viewer-2.0-11.el7.x86_64 virt-manager-1.4.0-1.el7.noarch spice-gtk-0.31-5.el7.x86_64 spice-gtk3-0.31-5.el7.x86_64 libvirt-2.0.0-4.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. Prepare a guest with spice graphical and password set. # virsh dumpxml rhel7.2released --security-info ... <graphics type='spice' autoport='yes' listen='127.0.0.1' passwd='12345678'> <listen type='address' address='127.0.0.1'/> </graphics> ... 2. Boot up guest. 3. Open the guest and type correct password, make sure you can login successfully. 4. Close the guest window and open the guest again, type wrong password(eg:131) and click login button. Actual results: After step4, login failed with error: Viewer authentication error: Authentication failed: password is required The error 'password is required' is not clear for user, in fact user has type a password though it's a wrong password. Expected results: Update error message when login failed. Additional info: