RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1365736 - Error message should be clear when connect to a spice guest with wrong password
Summary: Error message should be clear when connect to a spice guest with wrong password
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: spice-gtk
Version: 7.3
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Snir Sheriber
QA Contact: SPICE QE bug list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-10 06:15 UTC by zhoujunqin
Modified: 2017-08-01 15:04 UTC (History)
9 users (show)

Fixed In Version: spice-gtk-0.33-4.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 15:04:11 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
screenshot for step-4 (727.51 KB, image/png)
2016-08-10 06:15 UTC, zhoujunqin 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:1849 0 normal SHIPPED_LIVE virt-viewer bug fix and enhancement update 2017-08-01 17:49:46 UTC

Description zhoujunqin 2016-08-10 06:15:16 UTC 
Created attachment 1189469 [details]
screenshot for step-4

Description of problem:
Error message should be clear when connect to a spice guest with wrong password

Version-Release number of selected component (if applicable):
virt-viewer-2.0-11.el7.x86_64
virt-manager-1.4.0-1.el7.noarch
spice-gtk-0.31-5.el7.x86_64
spice-gtk3-0.31-5.el7.x86_64
libvirt-2.0.0-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a guest with spice graphical and password set.
# virsh dumpxml rhel7.2released --security-info
...
    <graphics type='spice' autoport='yes' listen='127.0.0.1' passwd='12345678'>
      <listen type='address' address='127.0.0.1'/>
    </graphics>
...

2. Boot up guest.

3. Open the guest and type correct password, make sure you can login successfully.

4. Close the guest window and open the guest again, type wrong password(eg:131) and click login button.

Actual results:
After step4, login failed with error:
Viewer authentication error: Authentication failed: password is required

The error 'password is required' is not clear for user, in fact user has type a password though it's a wrong password.

Expected results:
Update error message when login failed.

Additional info:
Comment 2 Pavel Grunt 2016-08-10 10:03:45 UTC 
I agree that would be nice to improve the error message. Most likely handling connection failures in general would have to be reworked -> moving to 7.4

(just a comment: virt-viewer / remote-viewer doesn't have the issue in case of failure it asks again for the password. Maybe error handling can be improved in virt-manager)
Comment 3 mxie@redhat.com 2017-01-18 04:16:56 UTC 
Hi Pavel,

I meet another problem when reproduce this bug. could you help to check whether below problem could be fixed with this bug together?

Description of problem:
Wrong password can't be cleared automatically after clicking "ok" for authentication failed dialog for spice guest

Version-Release number of selected component (if applicable):
virt-manager-1.4.0-2.el7.noarch
libvirt-2.0.0-10.el7_3.4.x86_64
qemu-kvm-rhev-2.6.0-28.el7_3.3

How reproducible:
100%

Steps to Reproduce:
1. Prepare a spice guest with password setting in virt-manager
2. Open the guest console and type wrong password, will pop up error "Viewer authentication error: Authentication failed: password is required"
3. Click "ok" for Authentication failed dialog, but the wrong password can't be cleared automatically


Actual results:
As subject

Expected results:
Wrong password can be cleared automatically after clicking "ok" for authentication failed dialog for spice guest

Additional info:
1.Wrong password can be cleared automatically after clicking "ok" for authentication failed dialog for VNC guest
Comment 4 Pavel Grunt 2017-01-18 09:13:44 UTC 
Hi,

clearing the password input must be done in virt-manager, so not in this bug
Comment 5 mxie@redhat.com 2017-01-18 09:22:15 UTC 
(In reply to Pavel Grunt from comment #4)
> Hi,
> 
> clearing the password input must be done in virt-manager, so not in this bug

Thanks for your reply. have filed one to track this problem https://bugzilla.redhat.com/show_bug.cgi?id=1414296
Comment 6 Snir Sheriber 2017-03-08 15:26:28 UTC 
possible fix:
https://patchwork.freedesktop.org/series/20263/
Comment 8 Xiaodai Wang 2017-03-28 02:35:00 UTC 
(In reply to Snir Sheriber from comment #6)
> possible fix:
> https://patchwork.freedesktop.org/series/20263/

I'd like to remove the blank space between 'password' and '?' in "wrong password ?".
Comment 9 Snir Sheriber 2017-03-30 12:05:32 UTC 
(In reply to xiaodwan from comment #8)
> (In reply to Snir Sheriber from comment #6)
> > possible fix:
> > https://patchwork.freedesktop.org/series/20263/
> 
> I'd like to remove the blank space between 'password' and '?' in "wrong
> password ?".

sure, np.
Comment 10 Radek Duda 2017-04-18 11:46:03 UTC 
(In reply to Snir Sheriber from comment #9)
> (In reply to xiaodwan from comment #8)
> > (In reply to Snir Sheriber from comment #6)
> > > possible fix:
> > > https://patchwork.freedesktop.org/series/20263/
> > 
> > I'd like to remove the blank space between 'password' and '?' in "wrong
> > password ?".
> 
> sure, np.

Actually why there is '?' at all? It is no doubt that password is wrong in that case isn't it? Given https://bugzilla.redhat.com/show_bug.cgi?id=1365736#c9 moving to assigned
Comment 11 Snir Sheriber 2017-04-23 12:43:33 UTC 
(In reply to Radek Duda from comment #10)
> (In reply to Snir Sheriber from comment #9)
> > (In reply to xiaodwan from comment #8)
> > > (In reply to Snir Sheriber from comment #6)
> > > > possible fix:
> > > > https://patchwork.freedesktop.org/series/20263/
> > > 
> > > I'd like to remove the blank space between 'password' and '?' in "wrong
> > > password ?".
> > 
> > sure, np.
> 
> Actually why there is '?' at all? It is no doubt that password is wrong in
> that case isn't it? Given
> https://bugzilla.redhat.com/show_bug.cgi?id=1365736#c9 moving to assigned

It will probably almost always show up because the password is wrong but theoretically it could happen for other reasons too (e.g. expire password ..)
Comment 12 Pavel Grunt 2017-05-10 08:07:54 UTC 
Fixed upstream since https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=366344f37bc756137b0c5009135088f4bf562b04
Comment 15 errata-xmlrpc 2017-08-01 15:04:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1849
Note You need to log in before you can comment on or make changes to this bug.