Bug 1373725
| Summary: | A dialog box pops up and can't be closed normally when drag a file into guest with filetransfer disabled. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Fangge Jin <fjin> | ||||
| Component: | spice | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> | ||||
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.3 | CC: | cfergeau, dblechte, dyuan, juzhou, mxie, mzhan, rbalakri, rduda, tpelka, tzheng, victortoso, xiaodwan | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | spice-0.13.90-1.el7 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1373830 (view as bug list) | Environment: | |||||
| Last Closed: | 2018-04-10 13:52:38 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
There are two problems: 1. the dialog showing up & transfer going on - spice server should tell spice-gtk, that file transfer is disabled 2. the dialog window cannot be closed - that is virt-viewer's problem Created attachment 1198587 [details]
The screenshot of virt-viewer
(In reply to Pavel Grunt from comment #2) > There are two problems: > 1. the dialog showing up & transfer going on - spice server should tell > spice-gtk, that file transfer is disabled > 2. the dialog window cannot be closed - that is virt-viewer's problem I opened the bug 1373830 for 2. (In reply to Pavel Grunt from comment #2) > There are two problems: > 1. the dialog showing up & transfer going on - spice server should tell > spice-gtk, that file transfer is disabled > 2. the dialog window cannot be closed - that is virt-viewer's problem The dialog showing up, but the transfer has no progress, which can be seen from the screenshot (In reply to JinFangge from comment #5) > (In reply to Pavel Grunt from comment #2) > > There are two problems: > > 1. the dialog showing up & transfer going on - spice server should tell > > spice-gtk, that file transfer is disabled > > 2. the dialog window cannot be closed - that is virt-viewer's problem > > The dialog showing up, but the transfer has no progress, which can be seen > from the screenshot Yes, it has no progress because the file transfer is disabled in spice-server. Patch posted - for server to tell spice-gtk that file transfer should not happen https://lists.freedesktop.org/archives/spice-devel/2016-December/034736.html *** Bug 1446142 has been marked as a duplicate of this bug. *** Fix did not get upstream, moving to 7.5 All should be upstream now: * Spice-protocol Shortlog: agent: Add capability for disabled file transfer Commit : 3f27d410b45262829897227abf64d57a81ff4910 Pavel Grunt on Fri, 10 Mar 2017 10:43:21 +0100 Shortlog: agent: Add macro for clearing capability Commit : b9bfbd2f7bc14274bb84364e9fd75e1448e3eaf5 Pavel Grunt on Fri, 3 Mar 2017 13:00:36 +0000 * Spice Shortlog: reds: Adjust agent capabilites to disabled features Commit : 366b5b96c21579156b6ef5601d6d458899269d99 Pavel Grunt on Tue, 6 Jun 2017 17:53:42 +0100 * Spice-gtk Shortlog: main: Handle disabled file transfer Commit : 40b0dbf3175ed8c5dba7f5a8058774c3aec93d9c Pavel Grunt on Fri, 10 Mar 2017 16:24:28 +0100 Fixed as part of the rebase, should be fixed client-side with the rebase to spice-gtk 0.34. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0802 |
DDescription of problem: Disable spice filetransfer for guest, start guest, open remote-viewer, try to drag a file into guest from host, a "File transfer" dialog box pops up, but it can't be closed by click "X" or "cancel" or "right click + close" Version-Release number of selected component: libvirt-2.0.0-6.el7.x86_64 virt-viewer-2.0-11.el7.x86_64 spice-gtk3-0.31-5.el7.x86_64 spice-server-0.12.4-18.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. Prepare a guest with spice graphic and filetransfer enable='no': # virsh edit rhel7.3-0817 ... <graphics type='spice' autoport='yes' listen='0.0.0.0'> <listen type='address' address='0.0.0.0'/> <filetransfer enable='no'/> </graphics> 2. Start guest # virsh start rhel7.3-0817 3. Connect to guest by remote-viewer: # remote-viewer spice://<ip>:<port> 4. Drag a file from host into guest. 5. Try to close the "File transfer" diglog Actual results: The "File transfer" dialog can't be closed Expected results: The "File transfer" dialog can be closed normally