Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1373830

Summary: File transfer dialog cannot be closed
Product: Red Hat Enterprise Linux 7 Reporter: Pavel Grunt <pgrunt>
Component: spice-gtkAssignee: Victor Toso <victortoso>
Status: CLOSED ERRATA QA Contact: SPICE QE bug list <spice-qe-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: dblechte, djasa, dyuan, fjin, juzhou, mtessun, mxie, mzhan, rbalakri, rduda, spice-qe-bugs, tzheng, victortoso, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: All   
Whiteboard:
Fixed In Version: spice-gtk-0.34-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1373725 Environment:
Last Closed: 2018-04-10 08:50:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Grunt 2016-09-07 08:41:19 UTC
When transferring a file to a guest the file transfer dialog window cannot be closed

Version-Release number of selected component:
virt-viewer-2.0-11.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. drag'n'drop files to make the file transfer dialog appear
2. try to close the dialog

Actual results:
The "File transfer" dialog can't be closed

Expected results:
The "File transfer" dialog can be closed normally


+++ This bug was initially created as a clone of Bug #1373725 +++

Description of problem:
Disable spice filetransfer for guest, start guest, open remote-viewer, try to drag a file into guest from host, a "File transfer" dialog box pops up, but it can't be closed by click "X" or "cancel" or "right click + close"

Version-Release number of selected component:
libvirt-2.0.0-6.el7.x86_64
virt-viewer-2.0-11.el7.x86_64
spice-gtk3-0.31-5.el7.x86_64
spice-server-0.12.4-18.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a guest with spice graphic and filetransfer enable='no':
# virsh edit rhel7.3-0817
...
    <graphics type='spice' autoport='yes' listen='0.0.0.0'>
      <listen type='address' address='0.0.0.0'/>
      <filetransfer enable='no'/>
    </graphics>

2. Start guest
# virsh start rhel7.3-0817

3. Connect to guest by remote-viewer:
# remote-viewer spice://<ip>:<port>

4. Drag a file from host into guest.

5. Try to close the "File transfer" dialog

Actual results:
The "File transfer" dialog can't be closed

Expected results:
The "File transfer" dialog can be closed normally

--- Additional comment from Pavel Grunt on 2016-09-07 04:35:08 EDT ---

There are two problems:
 1. the dialog showing up & transfer going on - spice server should tell spice-gtk, that file transfer is disabled
 2. the dialog window cannot be closed - that is virt-viewer's problem

Comment 1 Victor Toso 2017-05-30 14:00:53 UTC
Client side does not know that file-transfer is disabled in the host so the complete solution to the problem is not upstream yet. Moving to 7.5

Comment 2 Victor Toso 2017-07-03 13:43:50 UTC
This should potentially be fixed by [0], depending on expected behavior. It should pop up a dialog citing each file that has failed to transfer, without the rationale on why it has failed (probably by design). 

[0] https://lists.freedesktop.org/archives/spice-devel/2017-July/038469.html

The actual reason for failure can be seen as warning, for instance:
(remote-viewer:12620): virt-viewer-WARNING **: File transfer task 0x2a14b20 failed: The file transfer is disabled

Comment 7 Victor Toso 2017-11-16 09:37:44 UTC
As per comment #1, virt-viewer does not receive any errors from spice-gtk when a file-transfer failed due the fact that file-transfer was disabled in the host.

The fix is in spice-gtk so I'm moving to spice-gtk component...

Comment 9 Victor Toso 2017-11-16 09:51:01 UTC
For the record, patch which should fix this is

https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=c021bb051fac1b66199

Comment 10 Radek Duda 2017-11-23 13:39:06 UTC
Moving to verifies:

tested on client (rhel7.5):
virt-viewer-5.0-9.el7.x86_64
spice-gtk3-0.34-2.el7.x86_64

guest (rhel7.5):
spice-gtk3-0.34-2.el7.x86_64
spice-server-0.14.0-2.el7.x86_64
spice-glib-0.34-2.el7.x86_64

with single or multiple files xfer cancelling file xfer works ok.

Comment 13 errata-xmlrpc 2018-04-10 08:50:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0672