Bug 1376437
| Summary: | Review Request: golang-github-fatih-color - Color package for Go (golang) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Runge <mrunge> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-26 23:55:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1376407, 1376412, 1430143, 1462140 | ||
| Bug Blocks: | 1376389 | ||
|
Description
Matthias Runge
2016-09-15 12:25:47 UTC
- Please bump to the latest revision:
%global commit 1535ebc2637cc042c938f07fa26c6356ab8f8504
- Please provide a commitdate for versionning:
%global commitdate 20170905
And:
Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
Then:
* Mon Sep 18 2017 Matthias Runge <mrunge> - 0-0.1.20170905git1535ebc
- Remove vendored dependencies:
%install
rm -rf vendor
And remove:
Provides: golang(%{import_path}/vendor/github.com/mattn/go-colorable) = %{version}-%{release}
Provides: golang(%{import_path}/vendor/github.com/mattn/go-isatty) = %{version}-%{release}
- Sadly the go-isatty provided in Fedora is too old. You must request an update (bug #1462140).
Thank you, I've updated the package SPEC: http://www.matthias-runge.de/fedora/golang-github-fatih-color.spec SRPM: http://www.matthias-runge.de/fedora/golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26.src.rpm Everything is ok but you have to remove:
%dir %{gopath}/src/%{import_path}
in %files as it is marked as listed twice:
- Package does not contain duplicates in %files.
Note: warning: File listed twice:
/usr/share/gocode/src/gopkg.in/fatih/color.v1
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-fatih-color golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c4e3593e1 golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c4e3593e1 golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |