Bug 1376437 - Review Request: golang-github-fatih-color - Color package for Go (golang)
Summary: Review Request: golang-github-fatih-color - Color package for Go (golang)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1376407 1376412 1430143 1462140
Blocks: 1376389
TreeView+ depends on / blocked
 
Reported: 2016-09-15 12:25 UTC by Matthias Runge
Modified: 2017-09-26 23:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-26 23:55:11 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Matthias Runge 2016-09-15 12:25:47 UTC
Spec URL: https://mrunge.fedorapeople.org/reviews/golang-github-fatih-color/golang-github-fatih-color.spec

SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-fatih-color/golang-github-fatih-color-0-0.1.git4f7bcef.fc24.src.rpm

Description: Color package for Go (golang)

Fedora Account System Username: mrunge

$ rpmlint golang-github-fatih-color-0-0.1.git4f7bcef.fc24.src.rpm golang-github-fatih-color-devel-0-0.1.git4f7bcef.fc24.noarch.rpm golang-github-fatih-color-unit-test-devel-0-0.1.git4f7bcef.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Robert-André Mauchin 🐧 2017-09-18 07:40:34 UTC
 - Please bump to the latest revision:

%global commit          1535ebc2637cc042c938f07fa26c6356ab8f8504

 - Please provide a commitdate for versionning:

%global commitdate      20170905

   And:

Release:        0.1.%{commitdate}git%{shortcommit}%{?dist}

   Then:

* Mon Sep 18 2017 Matthias Runge <mrunge> - 0-0.1.20170905git1535ebc

 - Remove vendored dependencies:

%install
rm -rf vendor

   And remove:

Provides:      golang(%{import_path}/vendor/github.com/mattn/go-colorable) = %{version}-%{release}
Provides:      golang(%{import_path}/vendor/github.com/mattn/go-isatty) = %{version}-%{release}


 - Sadly the go-isatty provided in Fedora is too old. You must request an update (bug #1462140).

Comment 3 Robert-André Mauchin 🐧 2017-09-18 09:39:05 UTC
Everything is ok but you have to remove:

%dir %{gopath}/src/%{import_path}

in %files as it is marked as listed twice:

- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/gopkg.in/fatih/color.v1
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

Comment 4 Gwyn Ciesla 2017-09-18 12:45:17 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-fatih-color

Comment 5 Fedora Update System 2017-09-18 14:13:03 UTC
golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c4e3593e1

Comment 6 Fedora Update System 2017-09-19 04:22:05 UTC
golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c4e3593e1

Comment 7 Fedora Update System 2017-09-26 23:55:11 UTC
golang-github-fatih-color-0.1-0.1.20170905git1535ebc.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.