Bug 1385582

Summary: Custom button actions do not show up in request list
Product: Red Hat CloudForms Management Engine Reporter: Prasad Mukhedkar <pmukhedk>
Component: UI - OPSAssignee: Jozef Zigmund <jzigmund>
Status: CLOSED CURRENTRELEASE QA Contact: Dave Johnson <dajohnso>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: cbolz, dajohnso, dclarizi, gmccullo, hkataria, jhardy, mfalesni, mpovolny, obarenbo, pmukhedk, simaishi
Target Milestone: GA   
Target Release: 5.6.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-20 17:32:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1421829    
Bug Blocks:    
Attachments:
Description Flags
The Order Request stays on a page where was submitted none

Comment 2 Greg McCullough 2016-10-17 14:28:30 UTC 
As the code shows custom buttons do not create a request instance.  This would need to be an enhancement to support that feature.

I think the current issue is the redirection to the request page after the custom button is submitted.  Previously the custom button would remain on the same screen after it was submitted or canceled.
Comment 3 Harpreet Kataria 2016-10-17 14:48:15 UTC 
Jozef,

Can you look into this, when Service request is submitted, we should not redirect to list of Requests. We should only redirect to list of Requests screen for the Provisioning requests and other types that we show on Request List screen. Let me know if you want to discuss further.

Thanks,
~Harpreet
Comment 5 Harpreet Kataria 2016-11-07 16:15:13 UTC 
*** Bug 1392160 has been marked as a duplicate of this bug. ***
Comment 6 Jozef Zigmund 2017-03-22 09:42:53 UTC 
Hi, I cannot reproduce the issue, after submitting the custom button, it stayed on the page from where was the order request submitted with flash message "Order Request was Submitted". Test that on both devel branches - master and euwe(5.7.z) Could you please verify?
Comment 7 Jozef Zigmund 2017-03-22 09:44:21 UTC 
Created attachment 1265342 [details]
The Order Request stays on a page where was submitted
Comment 8 Jozef Zigmund 2017-03-22 09:46:34 UTC 
Created attachment 1265343 [details]
The Order Request stays on a page where was submitted
Comment 9 Christian Jung 2017-03-24 14:33:48 UTC 
I was looking into this once more:

5.6, button with dialog -> request queue (ERROR)
5.6, button without dialog - > back to original object (OK)

5.7, button with dialog -> request queue (OK)
5.7, button without dialog - > back to original object (OK)

So it looks like this is fixed since 5.7

HTH,
Christian
Comment 11 Jozef Zigmund 2017-05-09 13:40:37 UTC 
hi, I was trying to reproduce it on 5.6.z (darga branch), but unfortunately I was not able to reproduce that bug. After submission the Order Request, it stayed on Service show page with proper flash message. Please verify.
Comment 12 Christian Jung 2017-05-09 14:27:16 UTC 
HiHo,
did you create a button with a dialog associated? As I wrote in comment #9 it only happens if there is a dialog. If the button doesn't have a dialog, it goes back to the details page indeed.

Regards,
Christian
Comment 14 Dave Johnson 2017-08-17 20:59:35 UTC 
Milan, could you or one of your guys try to reproduce this.  Sounds like its fixed and should be moved to verified.

Thanks!
Comment 15 Milan Falešník 2017-08-18 08:55:58 UTC 
I tested it on 5.8.1.5, based on the PR description it does what it should it seems. Buttons return to details and service requests return to requests, IIUIC.
Comment 16 Satoe Imaishi 2017-09-20 17:32:01 UTC 
The mentioned PR is included in 5.6.4, 5.7.1 and 5.8.0.