Bug 1406848
| Summary: | Review Request: python-tackerclient - OpenStack NFV Orchestration Client | ||
|---|---|---|---|
| Product: | [Community] RDO | Reporter: | Dan Radez <dradez> |
| Component: | Package Review | Assignee: | hguemar |
| Status: | CLOSED DUPLICATE | QA Contact: | hguemar |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | trunk | CC: | amoralej, jpena |
| Target Milestone: | --- | ||
| Target Release: | trunk | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-22 13:38:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1329341 | ||
|
Description
Dan Radez
2016-12-21 16:04:19 UTC
Initial licensecheck output: $ licensecheck -r . ./tackerclient/version.py: Apache (v2.0) ./tackerclient/v1_0/client.py: Apache (v2.0) ./tackerclient/tests/unit/vm/test_vim_utils.py: Apache (v2.0) ./tackerclient/tests/unit/vm/test_cli10_vnffgd.py: *No copyright* Apache (v2.0) ./tackerclient/tests/unit/vm/test_cli10_vnffg.py: Apache (v2.0) ./tackerclient/tests/unit/vm/test_cli10_vnfd.py: Apache (v2.0) ./tackerclient/tests/unit/vm/test_cli10_vnf.py: Apache (v2.0) ./tackerclient/tests/unit/vm/test_cli10_vim.py: Apache (v2.0) ./tackerclient/tests/unit/vm/test_cli10_v10_event.py: Apache (v2.0) ./tackerclient/tests/unit/test_validators.py: Apache (v2.0) ./tackerclient/tests/unit/test_utils.py: Apache (v2.0) ./tackerclient/tests/unit/test_ssl.py: Apache (v2.0) ./tackerclient/tests/unit/test_shell.py: Apache (v2.0) ./tackerclient/tests/unit/test_http.py: Apache (v2.0) ./tackerclient/tests/unit/test_command_meta.py: Apache (v2.0) ./tackerclient/tests/unit/test_cli10_extensions.py: Apache (v2.0) ./tackerclient/tests/unit/test_cli10.py: Apache (v2.0) ./tackerclient/tests/unit/test_casual_args.py: Apache (v2.0) ./tackerclient/tests/unit/test_auth.py: Apache (v2.0) ./tackerclient/tacker/v1_0/vnfm/vnfd.py: Apache (v2.0) ./tackerclient/tacker/v1_0/vnfm/vnf.py: Apache (v2.0) ./tackerclient/tacker/v1_0/nfvo/vnffgd.py: *No copyright* Apache (v2.0) ./tackerclient/tacker/v1_0/nfvo/vnffg.py: *No copyright* Apache (v2.0) ./tackerclient/tacker/v1_0/nfvo/vim_utils.py: Apache (v2.0) ./tackerclient/tacker/v1_0/nfvo/vim.py: Apache (v2.0) ./tackerclient/tacker/v1_0/extension.py: Apache (v2.0) ./tackerclient/tacker/v1_0/events/events.py: Apache (v2.0) ./tackerclient/tacker/v1_0/__init__.py: Apache (v2.0) ./tackerclient/tacker/client.py: Apache (v2.0) ./tackerclient/shell.py: Apache (v2.0) ./tackerclient/i18n.py: *No copyright* Apache (v2.0) ./tackerclient/common/validators.py: Apache (v2.0) ./tackerclient/common/utils.py: Apache (v2.0) ./tackerclient/common/serializer.py: Apache (v2.0) ./tackerclient/common/extension.py: Apache (v2.0) ./tackerclient/common/exceptions.py: Apache (v2.0) ./tackerclient/common/constants.py: Apache (v2.0) ./tackerclient/common/command.py: Apache (v2.0) ./tackerclient/common/clientmanager.py: Apache (v2.0) ./tackerclient/common/_i18n.py: Apache (v2.0) ./tackerclient/client.py: Apache (v2.0) ./tacker_test.sh: *No copyright* UNKNOWN ./setup.py: Apache (v2.0) GENERATED FILE ./releasenotes/source/conf.py: Apache (v2.0) GENERATED FILE ./doc/source/conf.py: UNKNOWN ./LICENSE: *No copyright* GENERATED FILE The project is licensed using the Apache 2.0 license. The code seems to have started from the python-neutronclient code, judging from the git history, which is ok. Hi, Note that a package review for tackerclient was already approved for fedora in https://bugzilla.redhat.com/show_bug.cgi?id=1353224, so i think additional review for RDO is not required. We should re-use spec in http://pkgs.fedoraproject.org/cgit/rpms/python-tackerclient.git/tree and adjust it as needed so that it'll be easy to re-import in fedora in future. Best regards, Alfredo (In reply to Alfredo Moralejo from comment #2) > Hi, > > Note that a package review for tackerclient was already approved for fedora > in https://bugzilla.redhat.com/show_bug.cgi?id=1353224, so i think > additional review for RDO is not required. > > We should re-use spec in > http://pkgs.fedoraproject.org/cgit/rpms/python-tackerclient.git/tree and > adjust it as needed so that it'll be easy to re-import in fedora in future. > > Best regards, > > Alfredo True, I had forgotten about the Fedora review. I would propose we close this bug, and then change the commit message in https://review.rdoproject.org/r/#/c/4140/ to reference the Fedora review. Since the package is already approved, we can just import it and fix any DLRN-related issues. I'll close this duplcate and update the rdoinfo review, thanks! *** This bug has been marked as a duplicate of bug 1353224 *** |