Bug 1353224 - Review Request: python-tackerclient - Client for OpenStack tacker project
Summary: Review Request: python-tackerclient - Client for OpenStack tacker project
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1406848 (view as bug list)
Depends On:
Blocks: RDO-NEWTON 1354625
TreeView+ depends on / blocked
 
Reported: 2016-07-06 14:56 UTC by Alfredo Moralejo
Modified: 2016-12-22 13:38 UTC (History)
4 users (show)

Fixed In Version: python-tackerclient-0.7.0-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-23 11:14:19 UTC
Type: Bug
Embargoed:
karlthered: fedora-review+


Attachments (Terms of Use)

Description Alfredo Moralejo 2016-07-06 14:56:23 UTC
Tacker is an OpenStack based NFV Orchestrator service with built-in general purpose VNF Manager to deploy and operate Virtual Network Functions (VNFs) on an OpenStack based NFV Platform

Description: python-tackerclient provides the client library and executable to interact with OpenStack Tacker service.

SRPM URL: https://github.com/amoralej/python-tackerclient/raw/master/python-tackerclient-0.4.0-1.fc25.src.rpm
Spec URL: https://github.com/amoralej/python-tackerclient/raw/master/python-tackerclient.spec

Fedora Account System Username: amoralej

Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=14793473

Comment 1 hguemar 2016-07-06 16:07:43 UTC
I am sponsoring Alfredo, but informal reviews are welcome.
My FAS is hguemar, I'll make sure to switch accounts before changing flags.

Comment 2 Javier Peña 2016-09-01 15:51:51 UTC
The package looks good to me. The only nit is that the first Summary tag reads "OpenStack Example client".

Also, it should be updated to the last upstream version when building.

Comment 3 Javier Peña 2016-09-01 15:54:27 UTC
I've realized the spec requires python-oslo-utils >= 3.14.0, which is not yet available in Rawhide.

Comment 5 Javier Peña 2016-09-14 15:58:00 UTC
[Note] This is an informal review. The spec looks good to me:


-------------------------------
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 10 files have unknown license. Detailed output of
     licensecheck in /tmp/1353224-python-tackerclient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-tackerclient , python2-tackerclient-tests-unit , python-
     tackerclient-doc , python3-tackerclient , python3-tackerclient-tests-
     unit
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-tackerclient-0.7.0-1.fc26.noarch.rpm
          python2-tackerclient-tests-unit-0.7.0-1.fc26.noarch.rpm
          python-tackerclient-doc-0.7.0-1.fc26.noarch.rpm
          python3-tackerclient-0.7.0-1.fc26.noarch.rpm
          python3-tackerclient-tests-unit-0.7.0-1.fc26.noarch.rpm
          python-tackerclient-0.7.0-1.fc26.src.rpm
python2-tackerclient.noarch: W: no-manual-page-for-binary tacker-2
python2-tackerclient.noarch: W: no-manual-page-for-binary tacker
python2-tackerclient.noarch: W: no-manual-page-for-binary tacker-2.7
python2-tackerclient-tests-unit.noarch: W: no-documentation
python-tackerclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-tackerclient-doc/html/objects.inv
python3-tackerclient.noarch: W: no-documentation
python3-tackerclient.noarch: W: no-manual-page-for-binary tacker-3
python3-tackerclient.noarch: W: no-manual-page-for-binary tacker-3.5
python3-tackerclient-tests-unit.noarch: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
python-tackerclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-tackerclient-doc/html/objects.inv
python2-tackerclient.noarch: W: no-manual-page-for-binary tacker
python2-tackerclient.noarch: W: no-manual-page-for-binary tacker-2
python2-tackerclient.noarch: W: no-manual-page-for-binary tacker-2.7
python3-tackerclient-tests-unit.noarch: W: no-documentation
python2-tackerclient-tests-unit.noarch: W: no-documentation
python3-tackerclient.noarch: W: no-documentation
python3-tackerclient.noarch: W: no-manual-page-for-binary tacker-3
python3-tackerclient.noarch: W: no-manual-page-for-binary tacker-3.5
5 packages and 0 specfiles checked; 0 errors, 9 warnings.



Requires
--------
python-tackerclient-doc (rpmlib, GLIBC filtered):

python2-tackerclient (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)
    python-babel
    python-cliff
    python-iso8601
    python-keystoneclient
    python-netaddr
    python-oslo-i18n
    python-oslo-log
    python-oslo-serialization
    python-oslo-sphinx
    python-oslo-utils
    python-requests
    python-simplejson
    python-six

python3-tackerclient-tests-unit (rpmlib, GLIBC filtered):
    python(abi)
    python3-cliff-tablib
    python3-coverage
    python3-fixtures
    python3-flake8
    python3-hacking
    python3-mox3
    python3-oslo-log
    python3-oslo-serialization
    python3-pbr
    python3-pep8
    python3-pyflakes
    python3-reno
    python3-setuptools
    python3-sphinx
    python3-subunit
    python3-tackerclient
    python3-testrepository
    python3-testtools

python2-tackerclient-tests-unit (rpmlib, GLIBC filtered):
    pyflakes
    python(abi)
    python-cliff-tablib
    python-coverage
    python-fixtures
    python-flake8
    python-hacking
    python-mox
    python-oslo-log
    python-oslo-serialization
    python-pbr
    python-pep8
    python-reno
    python-setuptools
    python-sphinx
    python-subunit
    python-testrepository
    python-testtools
    python2-tackerclient

python3-tackerclient (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3-babel
    python3-cliff
    python3-iso8601
    python3-keystoneclient
    python3-netaddr
    python3-oslo-i18n
    python3-oslo-log
    python3-oslo-serialization
    python3-oslo-sphinx
    python3-oslo-utils
    python3-requests
    python3-simplejson
    python3-six



Provides
--------
python-tackerclient-doc:
    python-tackerclient-doc

python2-tackerclient:
    python-tackerclient
    python2-tackerclient
    python2.7dist(python-tackerclient)
    python2dist(python-tackerclient)

python3-tackerclient-tests-unit:
    python3-tackerclient-tests-unit

python2-tackerclient-tests-unit:
    python2-tackerclient-tests-unit

python3-tackerclient:
    python3-tackerclient
    python3.5dist(python-tackerclient)
    python3dist(python-tackerclient)



Source checksums
----------------
http://tarballs.openstack.org/python-tackerclient/python-tackerclient-0.7.0.tar.gz :
  CHECKSUM(SHA256) this package     : d3fe43229cf1cc12e7fbba452b92d5a4389e445ea7f6b2a309c6c38c9a77dc7c
  CHECKSUM(SHA256) upstream package : d3fe43229cf1cc12e7fbba452b92d5a4389e445ea7f6b2a309c6c38c9a77dc7c


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1353224 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 6 Haïkel Guémar 2016-09-17 08:31:00 UTC
(Removed FE-NEEDSPONSOR as I already sponsored Alfredo)

Good job on tackerclient, I confirm Javier's informal review, so I hereby approve this package, please a request on pkgdb.

Comment 7 Gwyn Ciesla 2016-09-20 14:33:14 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-tackerclient

Comment 8 Alfredo Moralejo 2016-09-23 11:17:24 UTC
Built in http://koji.fedoraproject.org/koji/buildinfo?buildID=802727 for fedora rawhide.

Comment 9 Dan Radez 2016-12-22 13:38:39 UTC
*** Bug 1406848 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.