Bug 1409387

Summary:	Review Request: python-sanic - Microframework based on uvloop, httptools, and learnings of flask
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-12 05:23:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1409378, 1409384, 1409386
Bug Blocks:

Description Igor Gnatenko 2017-01-01 14:47:23 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-sanic.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-sanic-0.1.9-1.fc26.src.rpm
Description:
Sanic is a Flask-like Python 3.5+ web server that's written to go fast.
It's based on the work done by the amazing folks at magicstack,
and was inspired by this article:
https://magic.io/blog/uvloop-blazing-fast-python-networking/.

On top of being Flask-like, Sanic supports async request handlers. This means
you can use the new shiny async/await syntax from Python 3.5,
making your code non-blocking and speedy.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2017-01-01 14:57:29 UTC

Taking this review.

Comment 2 Neal Gompa 2017-01-01 14:58:25 UTC

Initial note:

>Requires:       python%{python3_version}dist(uvloop) >= 0.5.3
>Requires:       python%{python3_version}dist(httptools) >= 0.0.9
>Requires:       python%{python3_version}dist(ujson) >= 1.35
>Requires:       python%{python3_version}dist(aiofiles) >= 0.3.0
>Requires:       python%{python3_version}dist(multidict) >= 2.0

Do you mean to do this? This will restrict sanic to only Fedora 25 and newer.

Comment 3 Igor Gnatenko 2017-01-01 15:02:16 UTC

(In reply to Neal Gompa from comment #2)
> Initial note:
> 
> >Requires:       python%{python3_version}dist(uvloop) >= 0.5.3
> >Requires:       python%{python3_version}dist(httptools) >= 0.0.9
> >Requires:       python%{python3_version}dist(ujson) >= 1.35
> >Requires:       python%{python3_version}dist(aiofiles) >= 0.3.0
> >Requires:       python%{python3_version}dist(multidict) >= 2.0
> 
> Do you mean to do this? This will restrict sanic to only Fedora 25 and newer.
Don't really care about such old distro-versions like F24 ;)

Comment 4 Neal Gompa 2017-01-01 15:43:46 UTC

Okay then. Be sure to only request F25 and Rawhide then.

Review notes:

- package is appropriately named
- license is properly declared (and license file properly marked in files list)
- package follows Python packaging guidelines


PACKAGE APPROVED.

Comment 5 Kevin Fenzi 2017-01-02 21:01:52 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-sanic

Comment 6 Fedora Update System 2017-01-03 09:48:34 UTC

python-sanic-0.1.9-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-794fa5cd7b

Comment 7 Fedora Update System 2017-01-03 22:21:20 UTC

python-sanic-0.1.9-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-794fa5cd7b

Comment 8 Fedora Update System 2017-01-12 05:23:52 UTC

python-sanic-0.1.9-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.