Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-sanic.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-sanic-0.1.9-1.fc26.src.rpm Description: Sanic is a Flask-like Python 3.5+ web server that's written to go fast. It's based on the work done by the amazing folks at magicstack, and was inspired by this article: https://magic.io/blog/uvloop-blazing-fast-python-networking/. On top of being Flask-like, Sanic supports async request handlers. This means you can use the new shiny async/await syntax from Python 3.5, making your code non-blocking and speedy. Fedora Account System Username: ignatenkobrain
Taking this review.
Initial note: >Requires: python%{python3_version}dist(uvloop) >= 0.5.3 >Requires: python%{python3_version}dist(httptools) >= 0.0.9 >Requires: python%{python3_version}dist(ujson) >= 1.35 >Requires: python%{python3_version}dist(aiofiles) >= 0.3.0 >Requires: python%{python3_version}dist(multidict) >= 2.0 Do you mean to do this? This will restrict sanic to only Fedora 25 and newer.
(In reply to Neal Gompa from comment #2) > Initial note: > > >Requires: python%{python3_version}dist(uvloop) >= 0.5.3 > >Requires: python%{python3_version}dist(httptools) >= 0.0.9 > >Requires: python%{python3_version}dist(ujson) >= 1.35 > >Requires: python%{python3_version}dist(aiofiles) >= 0.3.0 > >Requires: python%{python3_version}dist(multidict) >= 2.0 > > Do you mean to do this? This will restrict sanic to only Fedora 25 and newer. Don't really care about such old distro-versions like F24 ;)
Okay then. Be sure to only request F25 and Rawhide then. Review notes: - package is appropriately named - license is properly declared (and license file properly marked in files list) - package follows Python packaging guidelines PACKAGE APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-sanic
python-sanic-0.1.9-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-794fa5cd7b
python-sanic-0.1.9-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-794fa5cd7b
python-sanic-0.1.9-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.