Bug 1409378 - Review Request: python-aiofiles - File support for asyncio
Summary: Review Request: python-aiofiles - File support for asyncio
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1409387
TreeView+ depends on / blocked
 
Reported: 2017-01-01 13:02 UTC by Igor Gnatenko
Modified: 2017-01-12 05:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-01-12 05:23:10 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2017-01-01 13:02:04 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-aiofiles.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-aiofiles-0.3.0-1.fc26.src.rpm
Description:
aiofiles is an Apache2 licensed library, written in Python, for handling
local disk files in asyncio applications.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2017-01-01 13:26:32 UTC
Taking this review.

Comment 2 Neal Gompa 2017-01-01 13:33:36 UTC
Review notes:

- package is appropriately named
- license is properly declared (and license file properly marked in files list)
- package follows Python packaging guidelines
? python module is versioned inconsistently (contact upstream?)
* The code calls it 0.3.0, but the author has tagged as 0.3. Please contact upstream to fix the situation.

Also, please move "%global tagver 0.3" to the top of the spec to make it easier to read.

PACKAGE APPROVED.

Comment 3 Kevin Fenzi 2017-01-02 20:56:18 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-aiofiles

Comment 4 Fedora Update System 2017-01-02 21:24:18 UTC
python-aiofiles-0.3.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a7df5a080

Comment 5 Fedora Update System 2017-01-03 22:20:25 UTC
python-aiofiles-0.3.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a7df5a080

Comment 6 Fedora Update System 2017-01-12 05:23:10 UTC
python-aiofiles-0.3.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.