Bug 1426570

Summary: [DOCS] atomic-openshift-docker-excluder is missing
Product: OpenShift Container Platform Reporter: Joel Rosental R. <jrosenta>
Component: DocumentationAssignee: Alex Dellapenta <adellape>
Status: CLOSED CURRENTRELEASE QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact: Vikram Goyal <vigoyal>
Priority: medium    
Version: 3.4.0CC: adellape, aos-bugs, bandrade, clichybi, fmarchio, jokerman, jrosenta, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-22 19:15:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1430929, 1457379    
Bug Blocks:    

Description Joel Rosental R. 2017-02-24 10:53:07 UTC
Document URL: 

https://docs.openshift.com/container-platform/3.4/install_config/upgrading/automated_upgrades.html

Section Number and Name: 

- Using the Installer to Upgrade
- Upgrading to the Latest OpenShift Container Platform 3.4 Release

Describe the issue: 

In the install guide for openshift 3.3, docker 1.12 will be excluded in /etc/yum.conf (workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1417723).

If you plan updating to 3.4 and follow the documentation steps, you would still have docker 1.12 excluded in the /etc/yum.conf (which is required for OCP 3.4), hence the upgrade playbook will fail with a message like this:

"MSG:

This playbook requires access to Docker 1.12 or later"

Suggestions for improvement: 

An additional atomic-openshift-docker-excluder unexclude would also be needed.

Additional information:

Comment 1 Vikram Goyal 2017-03-06 07:13:47 UTC
*** Bug 1428852 has been marked as a duplicate of this bug. ***

Comment 2 Michael Burke 2017-03-08 00:37:45 UTC
(In reply to Joel Rosental R. from comment #0)
> Document URL: 
> 
> https://docs.openshift.com/container-platform/3.4/install_config/upgrading/
> automated_upgrades.html
> 
> Section Number and Name: 
> 
> - Using the Installer to Upgrade
> - Upgrading to the Latest OpenShift Container Platform 3.4 Release
> 
> Describe the issue: 
> 
> In the install guide for openshift 3.3, docker 1.12 will be excluded in
> /etc/yum.conf (workaround for
> https://bugzilla.redhat.com/show_bug.cgi?id=1417723).
> 
> If you plan updating to 3.4 and follow the documentation steps, you would
> still have docker 1.12 excluded in the /etc/yum.conf (which is required for
> OCP 3.4), hence the upgrade playbook will fail with a message like this:
> 
> "MSG:
> 
> This playbook requires access to Docker 1.12 or later"
> 
> Suggestions for improvement: 
> 
> An additional atomic-openshift-docker-excluder unexclude would also be
> needed.
> 
> Additional information:

Joel --

Are you suggesting that the user needs to run: `atomic-openshift-docker-excluder unexclude docker*1.12*` after the first excluder and before `atomic-openshift-installer upgrade` ? 

Michael

Comment 3 Joel Rosental R. 2017-03-08 08:17:55 UTC
Michael,

Yes, before `atomic-openshift-installer upgrade` or before running the upgrade playbook, otherwise docker-1.12 will still be in the exclude line in /etc/yum.conf and the upgrade to 3.4 will fail since it needs docker 1.12 package available through yum.

Comment 5 Joel Rosental R. 2017-03-09 08:28:49 UTC
Hi Michael,

Awesome, thanks.

Comment 6 Michael Burke 2017-03-09 15:02:12 UTC
@johnny 

Can you please take a look at this small change to make sure it looks correct?

Michael

Comment 8 Alex Dellapenta 2017-03-10 17:02:52 UTC
Talked w/ mburke and I've grabbed this BZ since I've been looking at the issue via OCP BZ https://bugzilla.redhat.com/show_bug.cgi?id=1430929.

Moving back to ASSIGNED for now.

Comment 9 Alex Dellapenta 2017-03-20 15:13:59 UTC
A fix to the excluder package has been merged in https://bugzilla.redhat.com/show_bug.cgi?id=1430929, but not sure yet what upcoming errata it will be released with.

In the meantime, I'm adding a workaround to the 3.4 upgrade docs after discussing with Troy. Will update again shortly.

Comment 10 Alex Dellapenta 2017-03-22 19:15:07 UTC
The workaround has been fixed via https://github.com/openshift/openshift-docs/pull/4009 and published.

Revision history:

https://docs.openshift.com/container-platform/3.4/welcome/revhistory_full.html#wed-mar-22-2017

Automated upgrade doc:

https://docs.openshift.com/container-platform/3.4/install_config/upgrading/automated_upgrades.html#preparing-for-an-automated-upgrade

With this workaround in place, they'll be getting the properly-installed atomic-openshift-docker-excluder package such that docker*1.12* is not in their excludes, so upgrades from 3.3 to 3.4 should not be blocked on not being able to upgrade to Docker 1.12.

We'll remove this workaround once the fix from https://bugzilla.redhat.com/show_bug.cgi?id=1430929 is shipped and the package can once again upgrade in-place properly.