Bug 1435118

Summary:	Review Request: perl-Dist-Zilla-Plugin-ReadmeAnyFromPod - Automatically convert POD to a README in any format for Dist::Zilla
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Dist-Zilla-Plugin-ReadmeAnyFromPod-0.163250-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-29 07:12:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1434503, 1435104, 1435108
Bug Blocks:	1435124

Description Petr Pisar 2017-03-23 08:21:12 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-ReadmeAnyFromPod/perl-Dist-Zilla-Plugin-ReadmeAnyFromPod.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-ReadmeAnyFromPod/perl-Dist-Zilla-Plugin-ReadmeAnyFromPod-0.163250-1.fc27.src.rpm
Description:
This Perl module generates a README for your Dist::Zilla-powered distribution
from its main_module in any of several formats. The generated README can be
included in the build or created in the root of your dist for e.g. inclusion
into version control.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-27 09:39:57 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Dist-Zilla-Plugin-ReadmeAnyFromPod-0.163250-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Dist::Zilla::File::InMemory)
      1 perl(Dist::Zilla::Role::AfterBuild)
      1 perl(Dist::Zilla::Role::AfterRelease)
      1 perl(Dist::Zilla::Role::FileGatherer)
      1 perl(Dist::Zilla::Role::FileMunger)
      1 perl(Dist::Zilla::Role::FilePruner)
      1 perl(Dist::Zilla::Role::FileWatcher)
      1 perl(Dist::Zilla::Role::PPI)
      1 perl(Encode)
      1 perl(List::Util) >= 1.33
      1 perl(Moose)
      1 perl(Moose::Util::TypeConstraints)
      1 perl(MooseX::Has::Sugar)
      1 perl(PPI::Document)
      1 perl(Path::Tiny) >= 0.004
      1 perl(Pod::Markdown) >= 2.000
      1 perl(Pod::Markdown::Github)
      1 perl(Pod::Simple::HTML) >= 3.23
      1 perl(Pod::Simple::Text) >= 3.23
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-ReadmeAnyFromPod-0.163250-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::ReadmeAnyFromPod) = 0.163250
      1 perl-Dist-Zilla-Plugin-ReadmeAnyFromPod = 0.163250-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-ReadmeAnyFromPod*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires are ok
FIX: perl(English) can be removed, because author tests are skipped in
     author-critic.t.

Please correct 'FIX' issue.

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-03-28 18:56:37 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-ReadmeAnyFromPod

Comment 3 Petr Pisar 2017-03-29 07:12:36 UTC

Thank you for the review and the repository. I removed the dependency.