Bug 1437471

Summary:	Review Request: golang-github-klauspost-reedsolomon - Reed-Solomon Erasure Coding in Go
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Athos Ribeiro <athoscribeiro>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	athoscribeiro, package-review
Target Milestone:	---	Flags:	athoscribeiro: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-09 21:24:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1375986, 1437463
Bug Blocks:	1438089

Description Fabio Valentini 2017-03-30 11:42:58 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon-1.3-1.fc25.src.rpm

Description: Reed-Solomon Erasure Coding in Go

Fedora Account System Username: decathorpe


I can't yet provide a koji scratch build, since one of the dependencies is not in fedora yet - 'golang(github.com/klauspost/cpuid)', but a COPR build for i386 and x86_64 on f24, f25 and f26 is available here: https://copr.fedorainfracloud.org/coprs/decathorpe/syncthing/build/534246/

This go package is one of the new (indirect) dependencies of syncthing 0.14.25.

Comment 1 Fabio Valentini 2017-04-22 09:27:25 UTC

koji scratch build for rawhide, now all dependencies are packaged:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19133915

The linked COPR build is no longer valid.

Comment 2 Athos Ribeiro 2017-05-02 19:39:18 UTC

Hi Fabio,

I am taking this review.

- The examples directory contains usage examples, shouldn't its content be packaged in %doc or not packaged at all?

Comment 3 Fabio Valentini 2017-05-03 08:25:10 UTC

You're right. I've removed the examples from the package. I've also removed the redundant conditional in %check.

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon-1.3-1.fc26.src.rpm

Comment 4 Athos Ribeiro 2017-05-03 16:28:48 UTC

License is OK
Binary Requires and Provides are OK
There are no rpmlint warnings nor errors
%check runs and tests pass

Package builds successfully and complies to the packaging guidelines.

Approved!

Comment 5 Fabio Valentini 2017-05-03 18:46:38 UTC

Thanks for the review!

Comment 6 Gwyn Ciesla 2017-05-04 12:37:03 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-klauspost-reedsolomon

Comment 7 Fedora Update System 2017-05-04 19:29:39 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-52b4de3bf1

Comment 8 Fedora Update System 2017-05-04 19:31:30 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f711b875be

Comment 9 Fedora Update System 2017-05-04 19:32:06 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1dab82433

Comment 10 Fedora Update System 2017-05-05 20:58:44 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1dab82433

Comment 11 Fedora Update System 2017-05-05 21:01:37 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f711b875be

Comment 12 Fedora Update System 2017-05-05 22:38:16 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-52b4de3bf1

Comment 13 Fedora Update System 2017-05-09 21:24:12 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-05-15 04:26:50 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-05-15 04:35:32 UTC

golang-github-klauspost-reedsolomon-1.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.