Spec URL: https://mrunge.fedorapeople.org/reviews/golang-github-klauspost-cpuid/golang-github-klauspost-cpuid.spec SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-klauspost-cpuid/golang-github-klauspost-cpuid-0-0.1.git09cded8.fc24.src.rpm Description: CPU feature identification for Go Fedora Account System Username: mrunge Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15630358 $ rpmlint golang-github-klauspost-cpuid-0-0.1.git09cded8.fc24.src.rpm golang-github-klauspost-cpuid-devel-0-0.1.git09cded8.fc24.noarch.rpm golang-github-klauspost-cpuid-unit-test-devel-0-0.1.git09cded8.fc24.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec SRPM: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-1.0-1.fc26.src.rpm
*** Bug 1437463 has been marked as a duplicate of this bug. ***
Taking this review. Initial recommendation: Please regenerate the .spec file with "gofed github2spec", it seems there's some legacy/outdated cruft in there. Also, if you package version 1.0, make sure to reference the correct %commit in the .spec file, too.
Fabio, thanks for looking at this: SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec SRPM: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-0-0.1.git09cded8.fc27.src.rpm
It looks like you made a copy-paste error, because this link is now pointing at the old version again.
The revision is the same created from the spec file. But apparently I had to modify the spec to fill in the summary and license. The commit fits together with the last commit on https://github.com/klauspost/cpuid I updated the linked files.
It works now, thanks. Suggestions for improvements: 1) Since you are packaging version 1.0, you should set > Version: 1.0 > Release: 1%{?dist} and correct it the changelog entry too (1.0-1). 2) You can drop the empty %if-endif blocks at lines 94, 86 and 68.
Additionally, a koji scratch build for rawhide would be nice.
Pinging submitter. I would like to finish up this review, since some of my pending packages depend on it.
sorry for the delay, and thank you for your patience SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec SRPM: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-1.0-1.src.rpm scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19055443
There's only one major issue left as far as I can see: The Release: tag is "1", when it should be "1%{?dist}". No other changes are necessary for this. A cosmetic issue is that the conditional block between lines 141 and 147 is redundant, since the expression is always the same, so you could replace this: > %if ! 0%{?with_bundled} > export GOPATH=%{buildroot}/%{gopath}:%{gopath} > %else > # No dependency directories so far > > export GOPATH=%{buildroot}/%{gopath}:%{gopath} > %endif with just this: > export GOPATH=%{buildroot}/%{gopath}:%{gopath} Otherwise, the package looks good. If you fix the Release tag, I will approve the package. I will leave it up to you if you want to clean up the redundant conditional.
(In reply to Fabio Valentini from comment #11) > > %if ! 0%{?with_bundled} > > export GOPATH=%{buildroot}/%{gopath}:%{gopath} > > %else > > # No dependency directories so far > > > > export GOPATH=%{buildroot}/%{gopath}:%{gopath} > > %endif > > with just this: > > > export GOPATH=%{buildroot}/%{gopath}:%{gopath} Good catch! I fixed both. Updated SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec SRPM: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-1.0-1.fc27.src.rpm
Looks good now. Package approved.
By the way, please select at least f24, f25, f26 and master when you submit the package request. I need this package on those 4 releases :)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-klauspost-cpuid
golang-github-klauspost-cpuid-1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8d3f8fe472
golang-github-klauspost-cpuid-1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a09b41108c
golang-github-klauspost-cpuid-1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e25c40a33
golang-github-klauspost-cpuid-1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e25c40a33
golang-github-klauspost-cpuid-1.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8d3f8fe472
golang-github-klauspost-cpuid-1.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-klauspost-cpuid-1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-klauspost-cpuid-1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.