Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon-1.3-1.fc25.src.rpm Description: Reed-Solomon Erasure Coding in Go Fedora Account System Username: decathorpe I can't yet provide a koji scratch build, since one of the dependencies is not in fedora yet - 'golang(github.com/klauspost/cpuid)', but a COPR build for i386 and x86_64 on f24, f25 and f26 is available here: https://copr.fedorainfracloud.org/coprs/decathorpe/syncthing/build/534246/ This go package is one of the new (indirect) dependencies of syncthing 0.14.25.
koji scratch build for rawhide, now all dependencies are packaged: https://koji.fedoraproject.org/koji/taskinfo?taskID=19133915 The linked COPR build is no longer valid.
Hi Fabio, I am taking this review. - The examples directory contains usage examples, shouldn't its content be packaged in %doc or not packaged at all?
You're right. I've removed the examples from the package. I've also removed the redundant conditional in %check. Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-klauspost-reedsolomon-1.3-1.fc26.src.rpm
License is OK Binary Requires and Provides are OK There are no rpmlint warnings nor errors %check runs and tests pass Package builds successfully and complies to the packaging guidelines. Approved!
Thanks for the review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-klauspost-reedsolomon
golang-github-klauspost-reedsolomon-1.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-52b4de3bf1
golang-github-klauspost-reedsolomon-1.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f711b875be
golang-github-klauspost-reedsolomon-1.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1dab82433
golang-github-klauspost-reedsolomon-1.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1dab82433
golang-github-klauspost-reedsolomon-1.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f711b875be
golang-github-klauspost-reedsolomon-1.3-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-52b4de3bf1
golang-github-klauspost-reedsolomon-1.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-klauspost-reedsolomon-1.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-klauspost-reedsolomon-1.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.