Bug 1441023
| Summary: | Review Request: python-fontmake - Compile fonts from sources to binary | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Athos Ribeiro <athoscribeiro> |
| Component: | Package Review | Assignee: | Kalev Lember <klember> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | athoscribeiro, fedora, jamie.mansfield.jm, klember, package-review, panemade, shawn.starr |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-24 06:26:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1433757, 1435230, 1440992 | ||
| Bug Blocks: | 1258542, 1430589 | ||
|
Description
Athos Ribeiro
2017-04-11 02:27:48 UTC
New sources Spec URL: https://athoscr.fedorapeople.org/packaging/python-fontmake.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-fontmake-1.2.6-1.fc25.src.rpm I will review your packaging In order for me to review this, I'll have to build the other packages that depend on this and install locally in mock. This seems blocked from other dependencies. I will review when the other dependencies are resolved. More dependencies are being approved, still waiting Yes... In special, we have BZ#1440971, which requires an older ABI of a library we do have packaged in Fedora. python-booleanoperations is being reviewed, this will become unblocked and I will review latest .spec provided. Spec URL: https://athoscr.fedorapeople.org/packaging/python-fontmake.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-fontmake-1.4.0-1.fc27.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25216007 Thanks, I'll take a look at this today from a mock rawhide environment. Taking for review. Packaging looks nice and clean, but I'm wondering about the naming here. Wouldn't it be cleaner to call the source package 'fontmake' as upstream calls it, and then have 3 binary packages: fontmake, python2-fontmake, python3-fontmake? Similar to how Debian is packaging it (it has very similar python naming standards as we do): https://packages.debian.org/source/sid/fontmake Ping? Naming the package 'fontmake' makes sense (and still satisfies the Python packaging guidelines - 1). Though, given the impending deprecation of python2, should there really be a python2- package? The guidelines seem to suggest that python2 packages can only be introduced by special exemption (2), though perhaps that means for libraries/applications that exclusively run on python2. [1]: https://fedoraproject.org/wiki/Packaging:Python?rd=Packaging/Python#Naming [2]: https://fedoraproject.org/wiki/Packaging:Python?rd=Packaging/Python#Python_Version_Support Adding Needinfo on Reporter. If there is no reply from the reporter in next seven days let's close this and create a fresh package request by someone. If reporter comes back sometime later, we can add him as a co-maintainer if he needed. I'll retake this in a new bug with the existing packaging, if it's still around, the Hack font requires this and we want upstream support for this font in Fedora. Actually I am working with someone and that someone was supposed to submit this as a fresh request but that did not happened. So it will be good if Shawn can open a new package review bug. Thanks Shawn. Do add here know the new bug number. |