Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft-0.4.0-1.fc25.src.rpm Description: ufo2ft (“UFO to FontTools”) is a fork of ufo2fdk whose goal is to generate OpenType font binaries from UFOs (Unified Font Object) without the FDK dependency. Fedora Account System Username: athoscr
New version: Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft-0.4.2-1.fc25.src.rpm
It looks like tests are not passing on this one. Also it's an outdated version.
Hi Elliott, thanks for the input! :) Updated version and koji build Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft-0.6.2-1.fc26.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21450989
This seems to require a new version of compreffor, which doesn't seem to pip install properly (and should be using the Fedora package, anyway.)
(In reply to Elliott Sales de Andrade from comment #4) > This seems to require a new version of compreffor, which doesn't seem to pip > install properly (and should be using the Fedora package, anyway.) It does use the fedora package (check the koji build). You should wait for the new python-compreffor version to propagate to the mirrors if you are building it locally.
It'd be useful to add a version requirement so it wouldn't try to build at all. Not sure why I didn't get the updated compreffor (using Rawhide it should be there immediately) as it seems to have been built a while ago, but maybe just need to wait a little while for the mirrors to update.
Package Review ============== Looks good; APPROVED. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated". 73 files have unknown license. Detailed output of licensecheck in /home/elliott/rpmbuild/review/1435230-python-ufo2ft/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-ufo2ft , python3-ufo2ft [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-ufo2ft-0.6.2-1.fc28.noarch.rpm python3-ufo2ft-0.6.2-1.fc28.noarch.rpm python-ufo2ft-0.6.2-1.fc28.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python3-ufo2ft (rpmlib, GLIBC filtered): python(abi) python3-compreffor python3-cu2qu python3-defcon python3-fonttools python3-ufolib python2-ufo2ft (rpmlib, GLIBC filtered): python(abi) python2-compreffor python2-cu2qu python2-defcon python2-fonttools python2-ufolib Provides -------- python3-ufo2ft: python3-ufo2ft python3.6dist(ufo2ft) python3dist(ufo2ft) python2-ufo2ft: python-ufo2ft python2-ufo2ft python2.7dist(ufo2ft) python2dist(ufo2ft) Source checksums ---------------- https://github.com/googlei18n/ufo2ft/archive/v0.6.2/ufo2ft-0.6.2.tar.gz : CHECKSUM(SHA256) this package : ffd83d5c11ac7ba155c61cbe93574d28963494a7914555a6d6ecbd368db9aee3 CHECKSUM(SHA256) upstream package : ffd83d5c11ac7ba155c61cbe93574d28963494a7914555a6d6ecbd368db9aee3 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1435230 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for the review, Elliot! I will add the version requirements as suggested :)
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ufo2ft