Bug 1455690
| Summary: | Incorrect storage used in Chargeback reports | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ryan Spagnola <rspagnol> | ||||
| Component: | Reporting | Assignee: | Šimon Lukašík <slukasik> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nandini Chandra <nachandr> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.7.0 | CC: | cpelland, dajohnso, jhardy, lpichler, nachandr, obarenbo, rspagnol, simaishi, slukasik | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.9.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | storage:chargeback | ||||||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1459562 1459563 (view as bug list) | Environment: | |||||
| Last Closed: | 2018-03-06 15:55:38 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1459562, 1459563 | ||||||
| Attachments: |
|
||||||
We will be digging down in the history to see why this was added. Unless we find something meaningful, we will remove this calculation. Thanks! New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/afb10c142b4aafd8136ef8e153e5704d2a15c888 commit afb10c142b4aafd8136ef8e153e5704d2a15c888 Author: Šimon Lukašík <isimluk> AuthorDate: Wed May 31 14:18:43 2017 +0200 Commit: Šimon Lukašík <isimluk> CommitDate: Wed May 31 15:12:58 2017 +0200 Do not calculate useless group metrics https://bugzilla.redhat.com/show_bug.cgi?id=1455690 https://bugzilla.redhat.com/show_bug.cgi?id=1454456 - cpu is useless as it counts usagemhz and vm_numvcpus together - cpu_cores is useless as it only reports cpu_cores - memory is useless as counts used and available together - net_io is useless as it only reports net_ui_rate_avg - disk_io is useless as it only reports disk_usage_rate_avg - storage is useless as it counts used and allocated together - fixed is useless as it counts all the fixed metrics together (that equals to 4 for each day, not useful) app/models/chargeable_field.rb | 3 +-- spec/models/chargeback_vm_spec.rb | 6 ------ 2 files changed, 1 insertion(+), 8 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/22570acb78e1c72752b76d37c45b5f8e4369d6a2 commit 22570acb78e1c72752b76d37c45b5f8e4369d6a2 Author: Šimon Lukašík <isimluk> AuthorDate: Wed May 31 15:24:57 2017 +0200 Commit: Šimon Lukašík <isimluk> CommitDate: Wed May 31 15:24:57 2017 +0200 Do not offer report columns that are useless See https://github.com/ManageIQ/manageiq/pull/15260 to learn why this is not useful. https://bugzilla.redhat.com/show_bug.cgi?id=1455690 https://bugzilla.redhat.com/show_bug.cgi?id=1454456 app/models/chargeback_vm.rb | 6 ------ 1 file changed, 6 deletions(-) Affected columns: (see comment 7) As a fix we will no longer offer these columns to the user (when creating new report). If the report existed prior this update, we no longer calculate these columns. Thus, existing reports will have these columns blank. We advice users to remove affected columns themselves in the report editor. Removing these columns automatically required db migration and db migration is not planned for upcoming minor release. *** Bug 1454456 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/a5c8a79363ef3a470fe1315d6456011bcd47e9a1 commit a5c8a79363ef3a470fe1315d6456011bcd47e9a1 Author: Šimon Lukašík <isimluk> AuthorDate: Wed May 31 14:18:43 2017 +0200 Commit: Šimon Lukašík <isimluk> CommitDate: Thu Jun 8 10:34:42 2017 +0200 Do not calculate useless group metrics https://bugzilla.redhat.com/show_bug.cgi?id=1455690 https://bugzilla.redhat.com/show_bug.cgi?id=1454456 - cpu is useless as it counts usagemhz and vm_numvcpus together - cpu_cores is useless as it only reports cpu_cores - memory is useless as counts used and available together - net_io is useless as it only reports net_ui_rate_avg - disk_io is useless as it only reports disk_usage_rate_avg - storage is useless as it counts used and allocated together - fixed is useless as it counts all the fixed metrics together (that equals to 4 for each day, not useful) (cherry picked from commit afb10c142b4aafd8136ef8e153e5704d2a15c888) Conflicts: app/models/chargeable_field.rb spec/models/chargeback_vm_spec.rb app/models/chargeback_rate_detail.rb | 3 +-- spec/models/chargeback_vm_spec.rb | 6 ------ 2 files changed, 1 insertion(+), 8 deletions(-) Verified in 5.9.0.5 |
Created attachment 1282363 [details] incorrect storage amount Description of problem: Values not displaying properly in chargeback reports for storage Version-Release number of selected component (if applicable): 5.7.2.1 How reproducible: When running a report the total storage is always showing as sum of allocated and used storage. Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: The total storage is consistently the sum of allocated storage and used storage, effectively doubling the value of what is assigned to any particular vm