Bug 1459146

Currently upstream recommend.conf contains preferences only for upstream profiles, but atomic-openshift-node-guest is not in upstream. I can see two possible solutions:

a) merge atomic-openshift-node-guest into Tuned upstream and add its record into the upstream recommend.conf. In such case we need to find a way how to reliable detect OCP 3.5 (the /etc/system-release-cpe doesn't seem to be helpful), or

b) pack /etc/tuned/recommend.conf into the package providing atomic-openshift-node-guest. In such case it's not Tuned bug, but such approach doesn't scale well, because multiple 3rd party packages cannot install multiple /etc/tuned/recommend.conf. In Tuned we could address it by e.g. providing /etc/tuned/recommend.d directory where multiple 3rd party packages could install their recommend.conf

To be clear, when tuned-profiles-atomic-openshift-node is installed it does congifure the desired profile using scripts in its pre/post config. I understand it's desirable for `tuned-adm recommend` to provide the same recommendation as the pre/post scripts configure.

Aside from making recommend work, is there something that's causing the active profile to be reset?

Here's the scripts btw :
# rpm -q --scripts tuned-profiles-atomic-openshift-node 
postinstall scriptlet (using /bin/sh):
recommended=`/usr/sbin/tuned-adm recommend`
if [[ "${recommended}" =~ guest ]] ; then
  /usr/sbin/tuned-adm profile atomic-openshift-node-guest > /dev/null 2>&1
else
  /usr/sbin/tuned-adm profile atomic-openshift-node-host > /dev/null 2>&1
fi

preuninstall scriptlet (using /bin/sh):
# reset the tuned profile to the recommended profile
# $1 = 0 when we're being removed > 0 during upgrades
if [ "$1" = 0 ]; then
  recommended=`/usr/sbin/tuned-adm recommend`
  /usr/sbin/tuned-adm profile $recommended > /dev/null 2>&1
fi

It seems that https://bugzilla.redhat.com/show_bug.cgi?id=1459146#c0 did not describe the situation as clearly as it could:
1) OCP 3.5 master and nodes are running in "thick" mode in RHEL 7.3
2) Master/nodes are VMs on RHV 4.0 hypervisors
3) The active profile is *not* reset -- it is "atomic-openshift-node-guest"
   a) virt-what returns "kvm"
   b) /etc/system-release-cpe contains "cpe:/o:redhat:enterprise_linux:7.3:ga:server"
   c) This causes "tuned-adm recommend" to return "virtual-guest"
4) As https://bugzilla.redhat.com/show_bug.cgi?id=1459146#c8 shows, the installer uses atomic-openshift-node-guest (due to 3).  I did verify the scripts matched the listing above.

The tuned-adm profile has not been changed from the original installation.

Is atomic-openshift-node-host the expected profile for this situation?

atomic-openshift-node-guest is the profile I'd expect for this host, if it were bare metal then it'd be atomic-openshift-node-host

(In reply to Scott Dodson from comment #8)
> Aside from making recommend work, is there something that's causing the
> active profile to be reset?
>
I am not sure whether I understand the question correctly, but if /etc/tuned/active_profile doesn't exist or is empty when Tuned is started, it sets the same profile as 'tuned-adm recommend' prints .

(In reply to Thom Carlin from comment #9)
> It seems that https://bugzilla.redhat.com/show_bug.cgi?id=1459146#c0 did not
> describe the situation as clearly as it could:
> 1) OCP 3.5 master and nodes are running in "thick" mode in RHEL 7.3
> 2) Master/nodes are VMs on RHV 4.0 hypervisors
> 3) The active profile is *not* reset -- it is "atomic-openshift-node-guest"
>    a) virt-what returns "kvm"
>    b) /etc/system-release-cpe contains
> "cpe:/o:redhat:enterprise_linux:7.3:ga:server"
>    c) This causes "tuned-adm recommend" to return "virtual-guest"
> 4) As https://bugzilla.redhat.com/show_bug.cgi?id=1459146#c8 shows, the
> installer uses atomic-openshift-node-guest (due to 3).  I did verify the
> scripts matched the listing above.
> 

Unfortunately the "fingerprint" (virt-what and /etc/system-release-cpe) doesn't seem to be enough to deduce that it's OCP and that atomic-openshift-node* should be used. Is there anything more which could be used for unique identification (across other products)?

If not, it also shouldn't be problem, we could use e.g. the following for /etc/tuned/recommend.d/ocp.conf (when implemented)

[atomic-openshift-node-guest]
virt=.+

[atomic-openshift-node-host]

I.e. if tuned-profiles-atomic-openshift-node is installed, it will set atomic-openshift-node-host on bare metal and atomic-openshift-node-guest otherwise. I.e. the tuned-profiles-atomic-openshift-node specific recommend.conf (/etc/tuned/recommend.d/ocp.conf in this case) will override the base recommend.conf.

The Tuned side of this feature has been merged upstream:
https://github.com/redhat-performance/tuned/pull/60

Rules can be installed into:
/usr/lib/tuned/recommend.d/
or
/etc/tuned/recommend.d/

For packages installed from Red Hat controlled repositories it's preferred to drop rules into:
/usr/lib/tuned/recommend.d/

The /etc/tuned/recommend.d/ can be used for override and is meant for third party packages or admin overrides.

tuned-2.9.0-0.1.rc1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d9c6b990df

tuned-2.9.0-0.1.rc1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d9c6b990df

tuned-2.9.0-0.1.rc1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5f0849d207

/usr/lib/tuned/recommend.d is already installed by tuned-2.9.0-0.1.rc1.el7.noarch.

About the left issues described in https://bugzilla.redhat.com/show_bug.cgi?id=1459146#c28, I open clone this bug to openshift product to track it.

tuned-2.9.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e45ce4685

tuned-2.9.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c30e9bd1ea

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0879