Bug 1459861

Summary:	Disable the ability to deploy with custom cluster names
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Alfredo Deza <adeza>
Component:	Ceph-Ansible	Assignee:	Guillaume Abrioux <gabrioux>
Status:	CLOSED DUPLICATE	QA Contact:	ceph-qe-bugs <ceph-qe-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.0	CC:	adeza, aschoen, ceph-eng-bugs, flucifre, gabrioux, gmeno, johfulto, nthomas, sankarshan, seb, shan
Target Milestone:	rc	Keywords:	Reopened
Target Release:	3.*
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Deprecated Functionality
Doc Text:	Custom cluster names are no longer supported	Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-01-10 16:22:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1502021, 1507943

Description Alfredo Deza 2017-06-08 11:58:25 UTC

Description of problem: Ceph will stop supporting custom cluster names, so deployment tools must be first in disallowing that customization.



Additional info:
Discussed in the June 6th CDM, this was mostly a novelty to allow multiple clusters in a single node which doesn't even work today as the systemd scripts read the variable from /etc/sysconfig/

Comment 3 seb 2017-06-13 09:48:39 UTC

How do we maintain backward compatibility for this?

Comment 4 Alfredo Deza 2017-06-13 12:03:11 UTC

The deployment tools will not maintain backward compatibility explicitly in this case.

Ceph itself can still have custom cluster names, and the first step to prevent users from having custom cluster names is to have deployment tools stop exposing this feature.

Everything on the Ceph side will still be supported.

Comment 5 seb 2017-06-13 12:53:18 UTC

Alright, thanks.

However, with containers, I think there is a real use case for that and we are not dependant of systemd and how it reads Ceph's config file since we have our own.

Can this decision be revisited?

Comment 6 Christina Meno 2017-06-13 17:27:42 UTC

I think that we should offer to upgrade clusters that aren't named ceph.
Would we rename them? What do you think acceptable behavior is here?

Comment 7 Alfredo Deza 2017-06-14 12:13:38 UTC

Discussed this with Sebastien with more detail. Ceph is not going to stop working with custom cluster names, just that the deployment tools will stop allowing using ``--cluster`` to configure clusters.

I believe that the upgrade path means moving /etc/ceph/<custom cluster name>.conf to /etc/ceph/ceph.conf which sounds reasonable.

In that case I think ceph-ansible should have a separate step to do this change, and prevent playbook execution if custom cluster names are used.

Comment 8 seb 2017-06-14 15:21:15 UTC

Renaming a cluster that isn't named Ceph would break customer's scripts. Also, we would not only have to change the ceph.conf but also rename all the key in /etc/ceph and /var/lib/ceph/bootstrap-*/

The more I think about it, the more I'm worried about breaking too many things.

I think we should just remove the variable 'cluster' from group_vars to hide it. So if someone has this option enabled (for a cluster not named Ceph) then nothing would break. In the code, we will just declare this variable with a default to 'ceph'. 

With that, we don't break upgrades or existing no-named-ceph clusters and also we don't encourage people using a different cluster name since we 'hide' the functionality. I suspect a warning might be valuable too if we detect a cluster name not named Ceph...

Comment 10 seb 2017-07-06 15:14:55 UTC

As discussed with Alfredo, we want to keep the multi-cluster support around for several use-cases:


- Ceph cluster on demand with containers
- Distributed compute nodes
- rbd-mirror integration as part of OSPd
- Disaster scenario with OpenStack Cinder in OSPd

Also, we haven't had any major issues with this support so it'll be a bad idea to drop something so stable.
Thanks.

Comment 11 Alfredo Deza 2017-11-08 13:15:45 UTC

Re-opening as per discussion on ceph-devel http://lists.ceph.com/pipermail/ceph-users-ceph.com/2017-November/022244.html

This is really not only a problem of robustness in ceph-ansible, it is pervasive everywhere else. 

As of *today* ceph-disk has issues with custom cluster names, and ceph-volume just hit one issue with it that has just got fixed.

The following ceph-disk PR got closed because of the new discussion in ceph-devel 

https://github.com/ceph/ceph/pull/18638

That means that ceph-ansible will hit that problem if it continues to allow custom cluster name deployments.

Comment 13 Sébastien Han 2019-01-10 16:22:49 UTC


*** This bug has been marked as a duplicate of bug 1635924 ***