Bug 1460198

Summary:	RFE: enable LZ4 compression in spice-gtk
Product:	Red Hat Enterprise Linux 7	Reporter:	David Jaša <djasa>
Component:	spice-gtk	Assignee:	Victor Toso <victortoso>
Status:	CLOSED ERRATA	QA Contact:	SPICE QE bug list <spice-qe-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.4	CC:	cfergeau, jjongsma, mtessun, rbalakri, rduda, rh-spice-bugs, spice-qe-bugs, tpelka, victortoso
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	7.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spice-gtk-0.34-2.el7	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1460191	Environment:
Last Closed:	2018-04-10 08:50:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1432958
Bug Blocks:

Description David Jaša 2017-06-09 11:02:12 UTC

Description of problem:
LZ4 is good algorithm in both low CPU utilization and high compression ratio so it would be nice to have it as a RHEL default.
This bug depends on lz4 library inclusion in el7.

Version-Release number of selected component (if applicable):
RHEL 7.4 / spice-server-0.12.8-2.el7.x86_64

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Victor Toso 2017-06-09 11:07:55 UTC

Yes, Not much to be done in the codebase, we just need lz4 lib in.

Comment 5 Radek Duda 2017-12-19 15:07:22 UTC

could you give me a hint how to verify this one?
I see liblz4.so.1()(64bit) among required (rpm -qR spice-gtk3), but no mention of lz4 in spice-debug log nor debug log..
So how to detect that data are actually compressed?

Comment 6 Victor Toso 2017-12-19 16:16:19 UTC

(In reply to Radek Duda from comment #5)
> could you give me a hint how to verify this one?
> I see liblz4.so.1()(64bit) among required (rpm -qR spice-gtk3), but no
> mention of lz4 in spice-debug log nor debug log..
> So how to detect that data are actually compressed?

$ ldd /usr/lib64/libspice-client-gtk-3.0.so | grep -i lz4
        liblz4.so.1 => /usr/lib/liblz4.so.1 (0x00007fec70915000)

$ ldd /usr/lib64/libspice-client-glib-2.0.so | grep -i lz4
        liblz4.so.1 => /usr/lib/liblz4.so.1 (0x00007fba8bedc000)

$ remote-viewer --help-spice | grep -i lz4
  --spice-preferred-compression=<auto-glz,auto-lz,quic,glz,lz,lz4,off>  Preferred image compression algorithm

and you should have no problems while using lz4 compression.

Comment 10 errata-xmlrpc 2018-04-10 08:50:15 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0672