Bug 1460191
| Summary: | RFE: enable LZ4 compression in spice-server | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | David Jaša <djasa> | |
| Component: | spice | Assignee: | Snir Sheriber <ssheribe> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | SPICE QE bug list <spice-qe-bugs> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 8.1 | CC: | cfergeau, dblechte, djasa, fziglio, jjongsma, mtessun, ssheribe, tpelka, victortoso | |
| Target Milestone: | rc | Keywords: | FutureFeature | |
| Target Release: | 8.1 | Flags: | knoel:
mirror+
|
|
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | spice-0.14.0-1.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1460198 (view as bug list) | Environment: | ||
| Last Closed: | 2020-01-22 09:18:19 UTC | Type: | Feature Request | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1432958 | |||
| Bug Blocks: | ||||
|
Description
David Jaša
2017-06-09 10:53:40 UTC
That would be great in 7.5, yes! This strongly depends on bug#1432958 (inclusion of lz4 package in el7) which is not fixed yet, so for now cannot move forward with this bug. The spice-server-0.14.0-2.el7.x86_64 is built against lz4:
# ldd /usr/lib64/libspice-server.so.1 | grep lz
liblz4.so.1 => /lib64/liblz4.so.1 (0x00007f5a2b979000)
but the server can't be run with lz4 image compression specified:
/usr/libexec/qemu-kvm -vga qxl -monitor stdio -spice addr=::,port=5800,disable-ticketing,image-compression=lz4
qemu-kvm: spice: invalid image compression: lz4
When run without image-compression and connecting from client with --spice-preferred-compression=lz4 set, lz4 compression doesn't look like being selected either:
- client:
(virt-viewer:10238): GSpice-DEBUG: channel-display.c:968 display-2:0: spice_display_channel_up: cache_size 83886080, glz_window_size 50327552 (bytes)
(virt-viewer:10238): GSpice-DEBUG: channel-display.c:526 display-2:0: changing preferred compression to 7
- server:
(process:18497): Spice-DEBUG: display-channel.c:2380:display_channel_update_compression: jpeg disabled
(process:18497): Spice-DEBUG: display-channel.c:2381:display_channel_update_compression: zlib-over-glz disabled
No mention of lz4 use either in LAN or WAN conditions.
Moving to 7.6 (In reply to David Jaša from comment #7) > The spice-server-0.14.0-2.el7.x86_64 is built against lz4: > # ldd /usr/lib64/libspice-server.so.1 | grep lz > liblz4.so.1 => /lib64/liblz4.so.1 (0x00007f5a2b979000) > > but the server can't be run with lz4 image compression specified: > /usr/libexec/qemu-kvm -vga qxl -monitor stdio -spice > addr=::,port=5800,disable-ticketing,image-compression=lz4 > qemu-kvm: spice: invalid image compression: lz4 > This is 'expected', as https://patchwork.ozlabs.org/patch/432677/ was never resolved. > When run without image-compression and connecting from client with > --spice-preferred-compression=lz4 set, lz4 compression doesn't look like > being selected either: > - client: > (virt-viewer:10238): GSpice-DEBUG: channel-display.c:968 display-2:0: > spice_display_channel_up: cache_size 83886080, glz_window_size 50327552 > (bytes) > (virt-viewer:10238): GSpice-DEBUG: channel-display.c:526 display-2:0: > changing preferred compression to 7 '7' is indeed lz4 > > - server: > (process:18497): Spice-DEBUG: > display-channel.c:2380:display_channel_update_compression: jpeg disabled > (process:18497): Spice-DEBUG: > display-channel.c:2381:display_channel_update_compression: zlib-over-glz > disabled > > No mention of lz4 use either in LAN or WAN conditions. These messages are actually unrelated. At the moment there are no logs when setting the preferred compression algorithm, https://gitlab.freedesktop.org/spice/spice/blob/master/server/dcc.c#L1073 I'll add one upstream ;) RFE is moving to rhel 8, where it will be triaged and prioritized Hi David, looks like this is already working. Can you please doublecheck and CLOSE CURRENTRELEASE in case it does? We might need a RHV RFE for that eventually. Thanks! Martin While looking at another bug I was checking shared object, of spice-server (RHEL 8.2), you can see that LZ4 is enabled: $ objdump -T libspice-server.so.1|grep LZ4 0000000000000000 DF *UND* 0000000000000000 LZ4_decompress_safe_continue 0000000000000000 DF *UND* 0000000000000000 LZ4_compress_fast_continue 0000000000000000 DF *UND* 0000000000000000 LZ4_decompress_safe 0000000000000000 DF *UND* 0000000000000000 LZ4_compress_default 0000000000000000 DF *UND* 0000000000000000 LZ4_freeStream 0000000000000000 DF *UND* 0000000000000000 LZ4_createStreamDecode 0000000000000000 DF *UND* 0000000000000000 LZ4_createStream 0000000000000000 DF *UND* 0000000000000000 LZ4_freeStreamDecode 0000000000000000 DF *UND* 0000000000000000 LZ4_compressBound I assume this bug can be closed. closing based on #c14 The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |