Bug 1460588

Summary: [WALA] deprovision is executed even if input 'n'
Product: Red Hat Enterprise Linux 7 Reporter: Yuxin Sun <yuxisun>
Component: WALinuxAgentAssignee: Mohammed Gamal <mmorsy>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.4CC: ailan, mmorsy
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1460589 (view as bug list) Environment:
Last Closed: 2017-07-24 09:31:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1451172    
Bug Blocks: 1460589    

Description Yuxin Sun 2017-06-12 06:28:21 UTC 
Description of problem:
When we run "waagent -deprovision" and input "n" at the confirmation, the deprovisioning is still executed.

Version-Release number of selected component (if applicable):
WALinuxAgent-2.2.12-1

RHEL Version:
RHEL-7.4/6.9

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running VM in Azure.
2. Ssh login. Run "waagent -deprovision" and input "n" and "Enter" at the confirmation(Do you want to proceed (y/n)n)

Actual results:
The deprovisioning is still executed.

Expected results:
The deprovisioning is not executed.

Additional info:
1. The root cause is in pa/deprovision/default.py Line#220, the return value of self.do_confirmation(force=force) is not used. So that no matter what we input, it will go on deprovisioning.
Comment 2 Mohammed Gamal 2017-06-22 11:34:00 UTC 
Fixed upstream: https://github.com/Azure/WALinuxAgent/issues/757
Still not released
Comment 3 Mohammed Gamal 2017-06-23 08:47:09 UTC 
WALA v2.2.14 has been released containing the fix
https://github.com/Azure/WALinuxAgent/releases/tag/v2.2.14
Comment 4 Yuxin Sun 2017-06-26 09:34:26 UTC 
Verify in WALinuxAgent-2.2.14-1.el7
Result: Pass
Steps: The same as description.
Comment 5 Yuxin Sun 2017-07-24 09:31:57 UTC 
Close this issue because WALinuxAgent-2.2.14-1.el7/6 has shipped.