Bug 1462661

Summary:	lk fop succeeds even when lock is not acquired on at least quorum number of bricks
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.11	CC:	bugs, ksubrahm
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1461792	Environment:
Last Closed:	2017-06-28 18:32:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1461792, 1463104
Bug Blocks:

Description Pranith Kumar K 2017-06-19 08:14:57 UTC

+++ This bug was initially created as a clone of Bug #1461792 +++

Description of problem:
When testing gluster-block we are seeing that even when just one of the bricks is up lk fop is succeeding. This can lead to problems. Fix AFR behavior where lk fop considers quorum count to decide if lk fop succeeds or not.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-06-15 07:20:05 EDT ---

REVIEW: https://review.gluster.org/17524 (cluster/afr: Implement quorum for lk fop) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Worker Ant on 2017-06-18 12:36:29 EDT ---

REVIEW: https://review.gluster.org/17524 (cluster/afr: Implement quorum for lk fop) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Worker Ant on 2017-06-19 01:17:32 EDT ---

COMMIT: https://review.gluster.org/17524 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 45ebcf7009f549f022c36b4d537eeac62ecfd020
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jun 12 22:06:18 2017 +0530

    cluster/afr: Implement quorum for lk fop
    
    Problem:
    At the moment when we have replica 3 or arbiter setup, even when
    lk succeeds on just one brick we give success to application which
    is wrong
    
    Fix:
    Consider quorum-number of successes as success when quorum is enabled.
    
    BUG: 1461792
    Change-Id: I5789e6eb5defb68f8a0eb9cd594d316f5cdebaea
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/17524
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>

Comment 1 Worker Ant 2017-06-20 07:02:32 UTC

REVIEW: https://review.gluster.org/17578 (cluster/afr: Implement quorum for lk fop) posted (#1) for review on release-3.11 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Worker Ant 2017-06-20 13:49:27 UTC

COMMIT: https://review.gluster.org/17578 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 6945c9b3dc3afd290ee12cd5f90a6c538b2aaf14
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jun 12 22:06:18 2017 +0530

    cluster/afr: Implement quorum for lk fop
    
    Problem:
    At the moment when we have replica 3 or arbiter setup, even when
    lk succeeds on just one brick we give success to application which
    is wrong
    
    Fix:
    Consider quorum-number of successes as success when quorum is enabled.
    
     >BUG: 1461792
     >Change-Id: I5789e6eb5defb68f8a0eb9cd594d316f5cdebaea
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: https://review.gluster.org/17524
     >Smoke: Gluster Build System <jenkins.org>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.org>
     >Reviewed-by: Ravishankar N <ravishankar>
    
    BUG: 1462661
    Change-Id: I5789e6eb5defb68f8a0eb9cd594d316f5cdebaea
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/17578
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-06-28 18:32:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.1, please open a new bug report.

glusterfs-3.11.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-June/000074.html
[2] https://www.gluster.org/pipermail/gluster-users/