Bug 1467858
| Summary: | [v2v] rephrase "Drivers ISO" label in the v2v dialog | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ilanit Stein <istein> | ||||
| Component: | Providers | Assignee: | Tomas Jelinek <tjelinek> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ilanit Stein <istein> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.8.0 | CC: | cpelland, gblomqui, istein, jfrey, jhardy, michal.skrivanek, nsimsolo, obarenbo, simaishi, tjelinek | ||||
| Target Milestone: | GA | Keywords: | Reopened, TestOnly, ZStream | ||||
| Target Release: | 5.9.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | rhev, v2v | ||||||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1480586 (view as bug list) | Environment: | |||||
| Last Closed: | 2018-03-06 15:32:52 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | RHEVM | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1480586 | ||||||
| Attachments: |
|
||||||
@Ilanit for such errors in dialogues made through automate (like the v2v dialog happens to be) please always provide the log/automation.log This bug is about: The name of field: "Drivers ISO". It should be either "Drivers" or "ISO domains", based on the field purpose. The tool tip help message, attached to this field, "ISO where drivers are located", should of course match this field: For field name "Drivers", can be: "Drivers found on ISO domain". For field name "ISO domains", can be: "ISO domains where drivers are located" So no need for logs, for this bug. Yes, sorry this comment was intended for bug https://bugzilla.redhat.com/show_bug.cgi?id=1467856 :) Regarding the intent of the listbox itself, it should reflect the list of ISOs (which themselves contain the appropriate driver(s)) of the ISO domain of the target (selected in the first lisbox) RHV provider. Please note that for this the domain should be added to the provider and refreshed. Closing since the text is as intended and the listbox <script> failure is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1467856 Reopen because even if "Drivers ISO" is sort of clear to be referring the ISO images of the drivers, The help message associated with it is wrong: "ISO where drivers are located" It is not ISO datastore where drivers are located, but rather ISO images of the Drivers. So should be something like: "Driver's ISO images" Also regarding "Drivers ISO" - maybe it will be more clear if it will be called: "Driver's ISO" So, we can change it to: Label: "Drivers ISO Images" Empty value: "--- select image from list ---" Tooltip: "Image where the drivers are located" maybe we can simplify this to: Label: "Drivers" Empty value: "--- select image from list ---" Tooltip: "Image with drivers" https://github.com/ManageIQ/manageiq-content/pull/169 https://github.com/ManageIQ/manageiq-providers-ovirt/pull/75 So, tu summarize what has been actually merged: checbox: label: Install Windows Drivers tooltip: Install necessary Windows drivers as a part of the conversion process empty value: -- select image from list -- label: Install Windows Drivers Tooltip: Image with drivers The checkbox will be checked/uncheck according to the source OS once https://bugzilla.redhat.com/show_bug.cgi?id=1472843 is implemented Verified on CFME-5.9.0.14/RHV-4.1.8 |
Created attachment 1294547 [details] Drivers ISO Description of problem: When marking 'install drivers' check box, a 'Drivers ISO' field is added to the v2v dialog. This added field has a tool tip message: "ISO where drivers are located" It seems that when marking the install drivers check box, a field of Driver should be added, containing the list of all available drivers. In that case the name 'Drivers ISO' should change into 'Driver', and tool tip change as well to some other relevant message. In case the intention here was to list the available ISO domains, then need to name this added field like 'ISO Domain'. Version-Release number of selected component (if applicable): CFME-5.8.1.0/RHV-4.1.3