Bug 1469469

Summary: Rename the usage of disable-multipath.sh script to blacklist_all_disks.sh
Product: [oVirt] cockpit-ovirt Reporter: SATHEESARAN <sasundar>
Component: GdeployAssignee: Gobinda Das <godas>
Status: CLOSED CURRENTRELEASE QA Contact: RamaKasturi <knarra>
Severity: high Docs Contact:
Priority: unspecified    
Version: 0.10.7-0.0.20CC: bugs, knarra, rbarry, sabose
Target Milestone: ovirt-4.1.8Keywords: Rebase
Target Release: ---Flags: sasundar: ovirt-4.1?
sasundar: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.10.10-0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-11 16:29:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description SATHEESARAN 2017-07-11 10:30:58 UTC
Description of problem:
-----------------------
The script 'disable_multipath.sh' is renamed to 'blacklist_all_disks.sh' with gdeploy-2.0.2-12.el7rhgs

When gdeploy-2.0.2-12.el7rhgs is used by oVirt, then the generated gdeploy config file needs to be updated

Version-Release number of selected component (if applicable):
-------------------------------------------------------------

How reproducible:
-----------------
NA

Steps to Reproduce:
-------------------
NA

Actual results:
----------------
disable_multipath.sh script is invoked from gdeploy

Expected results:
------------------
With gdeploy-2.0.2. to blacklist the local disks, one should use '/usr/share/gdeploy/scripts/blacklist_all_disks.sh '

Additional info:

Comment 3 RamaKasturi 2017-09-12 06:30:14 UTC
Verified and works fine with build cockpit-ovirt-dashboard-0.10.8-2.0.ovirt41.el7ev.noarch.

I see that the script disable_multipath.sh has been renamed to blacklist_all_disks.sh and ignore_script_errors parameter has been added.

[script3]
action=execute
file=/usr/share/gdeploy/scripts/blacklist_all_disks.sh
ignore_script_errors=no

Comment 4 SATHEESARAN 2017-09-14 12:03:08 UTC
The fix for this bug is reverted with the effect of this bug - https://bugzilla.redhat.com/show_bug.cgi?id=1491548 - as because the latest gdeploy which carries the associated fix is not yet available.

Making the required changes with bugzilla flags and acks

Comment 5 RamaKasturi 2017-12-01 09:55:51 UTC
Verified and works fine with build cockpit-ovirt-dashboard-0.10.10-0.el7ev.noarch

I see that the script file  disable-multipath.sh  has been changed to /usr/share/gdeploy/scripts/blacklist_all_disks.sh