Bug 1491548 - change the path of gdeploy scripts files in the generated gdeploy conf file to /usr/share/ansible/gdeploy/scripts and rename black_list_all_devices to disable-multipath.sh
Summary: change the path of gdeploy scripts files in the generated gdeploy conf file ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.10.7-0.0.20
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ovirt-4.1.6
: ---
Assignee: Gobinda Das
QA Contact: RamaKasturi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-14 06:49 UTC by RamaKasturi
Modified: 2017-10-16 10:09 UTC (History)
3 users (show)

Fixed In Version: cockpit-ovirt-dashboard-0.10.8-2.2.ovirt41.el7ev.noarch
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-16 10:09:28 UTC
oVirt Team: Gluster
Embargoed:
rule-engine: ovirt-4.1?
ykaul: blocker+
knarra: planning_ack?
rule-engine: devel_ack+
sasundar: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 81746 0 master POST Revert back path and blacklist_all_disks.sh changes for gdeploy 2017-09-14 09:54:58 UTC
oVirt gerrit 81756 0 ovirt-4.1 POST Revert back path and blacklist_all_disks.sh changes for gdeploy 2017-09-14 12:04:34 UTC

Description RamaKasturi 2017-09-14 06:49:32 UTC
Description of problem:
Due to bug fix latest gdeploy which is not yet released needs to be tagged to RHV-H 4.1.6 other wise any new installtions of RHHI will break. To avoid this issue this bug is being raised to revert the path of script files to older path which is /usr/share/ansible/gdeploy/scripts.

With older version of ansible available script black_list_all_devices is not present. So this has to be renamed back to disable-multipath.sh.

Version-Release number of selected component (if applicable):
cockpit-ovirt-dashboard-0.10.8-2.0.ovirt41.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Install latest RHV-H ISO
2. Start configuring gluster
3.

Actual results:
If gdeploy is not updated to latest which is gdeploy-2.0.2-14.el7rhgs.noarch then new installations of RHHI will break due to the change in gdeploy script file path.

Expected results:
path for gdeploy script files have to be changed to old path which is /usr/share/ansible/gdeploy/scripts

Rename the script back to disable-multipath.sh

Additional info:

[root@rhsqa-grafton4 ~]# ls -l /usr/share/ansible/gdeploy/scripts/
total 12
-rwxr-xr-x. 1 root root  512 May 12 17:34 disable-gluster-hooks.sh
-rwxr-xr-x. 1 root root  160 May 12 17:34 disable-multipath.sh
-rwxr-xr-x. 1 root root 3476 May 12 17:34 grafton-sanity-check.sh

Comment 1 SATHEESARAN 2017-09-14 07:00:17 UTC
Additional info

The following bugs brought in the required change earlier for RHHI 1.1 product, which includes gdeploy-2.0.2-14.el7rhgs as part of RHGS 3.3.0 

https://bugzilla.redhat.com/show_bug.cgi?id=1462082
https://bugzilla.redhat.com/show_bug.cgi?id=1469469

The fixes for these bugs needs to be reverted, as the latest gdeploy is still not available

Comment 2 RamaKasturi 2017-09-19 13:12:19 UTC
verified and works fine with build cockpit-ovirt-dashboard-0.10.8-2.2.ovirt41.el7ev.noarch.

With this build i see that gdeploy script file path has been changed to /usr/share/ansible/gdeploy/scripts.

[script1]
action=execute
ignore_script_errors=no
file=/usr/share/ansible/gdeploy/scripts/grafton-sanity-check.sh -d sdc -h 10.70.36.79,10.70.36.80,10.70.36.81

[script3]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-multipath.sh
ignore_script_errors=no

[script2]
action=execute
file=/usr/share/ansible/gdeploy/scripts/disable-gluster-hooks.sh



And black_list_all_devices has been renamed to disable-multipath.sh and the script has older code which stops and disables multipathd.

[root@rhsqa-grafton1 ~]# cat /usr/share/ansible/gdeploy/scripts/disable-multipath.sh 
#!/usr/bin/env bash

multipath -F
cat <<EOF>> /etc/multipath.conf
blacklist {
        devnode "*"
}
EOF

systemctl stop multipathd
systemctl disable multipathd


Note You need to log in before you can comment on or make changes to this bug.