Bug 1469469 - Rename the usage of disable-multipath.sh script to blacklist_all_disks.sh
Summary: Rename the usage of disable-multipath.sh script to blacklist_all_disks.sh
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.10.7-0.0.20
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.1.8
: ---
Assignee: Gobinda Das
QA Contact: RamaKasturi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-11 10:30 UTC by SATHEESARAN
Modified: 2017-12-11 16:29 UTC (History)
4 users (show)

Fixed In Version: cockpit-ovirt-0.10.10-0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-11 16:29:03 UTC
oVirt Team: Gluster
Embargoed:
sasundar: ovirt-4.1?
sasundar: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 80896 0 master MERGED Renamed disable-multipath.sh script to blacklist_all_disks.sh 2017-08-30 08:08:51 UTC
oVirt gerrit 80948 0 ovirt-4.1 MERGED Renamed disable-multipath.sh script to blacklist_all_disks.sh 2017-08-30 11:52:05 UTC
oVirt gerrit 82510 0 master MERGED Renamed disable-multipath.sh script to blacklist_all_disks.sh 2017-11-15 08:52:47 UTC
oVirt gerrit 84520 0 ovirt-4.1 MERGED Renamed disable-multipath.sh script to blacklist_all_disks.sh 2017-11-27 12:56:02 UTC

Description SATHEESARAN 2017-07-11 10:30:58 UTC
Description of problem:
-----------------------
The script 'disable_multipath.sh' is renamed to 'blacklist_all_disks.sh' with gdeploy-2.0.2-12.el7rhgs

When gdeploy-2.0.2-12.el7rhgs is used by oVirt, then the generated gdeploy config file needs to be updated

Version-Release number of selected component (if applicable):
-------------------------------------------------------------

How reproducible:
-----------------
NA

Steps to Reproduce:
-------------------
NA

Actual results:
----------------
disable_multipath.sh script is invoked from gdeploy

Expected results:
------------------
With gdeploy-2.0.2. to blacklist the local disks, one should use '/usr/share/gdeploy/scripts/blacklist_all_disks.sh '

Additional info:

Comment 3 RamaKasturi 2017-09-12 06:30:14 UTC
Verified and works fine with build cockpit-ovirt-dashboard-0.10.8-2.0.ovirt41.el7ev.noarch.

I see that the script disable_multipath.sh has been renamed to blacklist_all_disks.sh and ignore_script_errors parameter has been added.

[script3]
action=execute
file=/usr/share/gdeploy/scripts/blacklist_all_disks.sh
ignore_script_errors=no

Comment 4 SATHEESARAN 2017-09-14 12:03:08 UTC
The fix for this bug is reverted with the effect of this bug - https://bugzilla.redhat.com/show_bug.cgi?id=1491548 - as because the latest gdeploy which carries the associated fix is not yet available.

Making the required changes with bugzilla flags and acks

Comment 5 RamaKasturi 2017-12-01 09:55:51 UTC
Verified and works fine with build cockpit-ovirt-dashboard-0.10.10-0.el7ev.noarch

I see that the script file  disable-multipath.sh  has been changed to /usr/share/gdeploy/scripts/blacklist_all_disks.sh


Note You need to log in before you can comment on or make changes to this bug.