Bug 1473663

Summary: Review Request: perl-Shell-Guess - Make an educated guess about the shell in use
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Shell-Guess-0.06-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 12:43:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1473656    
Bug Blocks: 1473678, 1473705    

Description Petr Pisar 2017-07-21 12:00:51 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Shell-Guess/perl-Shell-Guess.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Shell-Guess/perl-Shell-Guess-0.06-1.fc27.src.rpm
Description:
The Shell::Guess Perl module makes a reasonably aggressive attempt to
determine the shell being employed by the user, either the shell that executed
the Perl script directly, or the users' login shell.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-07-31 12:28:57 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Shell-Guess-0.06-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(File::Spec)
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(strict)
      1 perl(Unix::Process)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Shell-Guess-0.06-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Shell::Guess) = 0.06
      1 perl-Shell-Guess = 0.06-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Shell-Guess*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved
Comment 2 Gwyn Ciesla 2017-08-01 12:22:10 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Shell-Guess
Comment 3 Petr Pisar 2017-08-01 12:43:17 UTC 
Thank you for the review and the repository.