Bug 1477569

Summary: [REST] - It's impossible to add a network with characters in the range between 50 to 256 because that vNIC profile limited to 50 character
Product: [oVirt] ovirt-engine Reporter: Ori Ben Sasson <obensass>
Component: BLL.NetworkAssignee: Leon Goldberg <lgoldber>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: high Docs Contact:
Priority: high    
Version: 4.2.0CC: bugs, danken, mburman
Target Milestone: ovirt-4.1.6Flags: rule-engine: ovirt-4.1+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-19 10:01:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1458407    
Attachments:
Description Flags
engine log none

Description Ori Ben Sasson 2017-08-02 11:59:04 UTC
Description of problem:
It's impossible to add a network with characters in the range between 50 to 256 because that vNIC profile limited to 50 character.

I get an error from engine log 
ERROR: value too long for type character varying(50)


Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170801132145.git3e12cf0.el7.centos.noarch

How reproducible:
100

Steps to Reproduce:
1. Create a network name in the range between 50 to 256 characters via REST

Actual results:
Failed to add network with vNIC profile that the name is greater than 50 characters 

Expected results:
Should work as expected

Comment 1 Ori Ben Sasson 2017-08-02 12:03:37 UTC
Created attachment 1308160 [details]
engine log

Comment 3 Meni Yakove 2017-08-28 08:42:59 UTC
From time to time the vNIC profile failed to create automatically when creating the network with special characters.

Comment 4 Leon Goldberg 2017-08-28 09:09:41 UTC

(In reply to Meni Yakove from comment #3)
> From time to time the vNIC profile failed to create automatically when
> creating the network with special characters.

That is irrelevant to this patch. The profiles aren't created with short names as well. vNIC profiles are no longer limited to 50/ascii characters, so the bug is essentially solved IMO.


Another separate bug should be opened for what you've described (so far I can't reproduce the problem. I've tried several computers, but I'll keep investigating)

Comment 5 Michael Burman 2017-08-28 11:24:58 UTC
Even if not relevant to the patch. This can't be tested when sometimes the vNIC created or not. Will be tested only when we will have a fix to the vNIC profile creation. The verification of the this bug depends on the separate bug.

Comment 6 Dan Kenigsberg 2017-08-29 15:16:16 UTC
This bug can be tested by QA; if you are verifying this now, please note that the network name must be alphanumeric until bug 1485928 is ON_QA as well, and keyboard is used to confirm network creation (bug 1485927)

Comment 7 Michael Burman 2017-08-30 08:34:02 UTC
Verified on - 4.1.6-0.1.el7