Bug 1478071

Summary: Set ceph_rhcs: true as default value in all.yml.sample
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: khartsoe <khartsoe>
Component: Ceph-AnsibleAssignee: Sébastien Han <shan>
Status: CLOSED ERRATA QA Contact: Pratik Surve <prsurve>
Severity: high Docs Contact: Anjana Suparna Sriram <asriram>
Priority: high    
Version: 3.0CC: adeza, anharris, aschoen, ceph-eng-bugs, gmeno, hnallurv, kdreyer, khartsoe, nthomas, sankarshan, seb, shan, vashastr
Target Milestone: rc   
Target Release: 3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: RHEL: ceph-ansible-3.0.0-0.1.rc9.el7cp Ubuntu: ceph-ansible_3.0.0~rc9-2redhat1 Doc Type: Release Note
Doc Text:
From now on, the file: group_vars/all.yml.sample as a reference to setup a RHCS cluster. Some of the variables are already pre-enabled, further customization is needed by the deployer for the deployment to actually successfully complete.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-05 23:39:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description khartsoe@redhat.com 2017-08-03 14:15:24 UTC
Description of problem:
Currently, user is required to manually uncomment and set "ceph_rhcs: true" when configuring ceph global settings. This requires an additional manual task during installation.

Version-Release number of selected component (if applicable):
2.x, etc.

How reproducible:
As root, create an all.yml file from the all.yml.sample file, uncomment and set  "ceph_rhcs: false" to "ceph_rhcs: true"

Steps to Reproduce:
Step 5:
https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/2/html-single/installation_guide_for_red_hat_enterprise_linux/#configuring_ceph_global_settings

Actual results:
all.yml.sample file default value is commented out and set to "ceph_rhcs: false"

Expected results:
all.yml.sample file default value should be "ceph_rhcs: true" (and uncommented) to prevent user action and therefore, reduce required user tasks during installation

Additional info:
https://docs.google.com/document/d/14c6cx2PY6xe2XC0N9sFY8Jc-VobAy_LjpTxJsrOL_q8/edit

Driven by RHCS-LT Process Improvement effort

Comment 2 seb 2017-08-03 14:59:33 UTC
It's tough to automate as we have Ubuntu and RHEL customers. If we had only RHEL customer I could autodetect the release and set ceph_rhcs to true and it will be easier. However I can't do that for customers using Ubuntu...

Comment 3 Ken Dreyer (Red Hat) 2017-08-03 16:13:58 UTC
For the ceph-ansible RPM, we could have a downstream-only patch (or sed command) that flips this value.

We intend to ship ceph-ansible DEBs too (bug 1436782), so we could do the same thing there.

Comment 4 seb 2017-08-03 19:43:13 UTC
Seems like a valid solution to me, I can also generate a rhcs.yml.sample file with the right parameters. Let me try something.

Comment 5 seb 2017-08-03 20:40:18 UTC
PR: here https://github.com/ceph/ceph-ansible/pull/1743

Comment 8 Ken Dreyer (Red Hat) 2017-08-30 19:59:18 UTC
Sebastien, does this require a docs change for users to use "rhcs.yml.sample" now instead of the upstream one?

Comment 9 seb 2017-08-30 21:37:44 UTC
Yes, it does

Comment 10 Vasishta 2017-09-12 11:39:04 UTC
Hi Sebastien,

I observed that 'ceph_rhcs' has been removed from both all.yml.sample and rhcs.yml.sample

Which is the corresponding variable to look for ? I though that 'ceph_rhcs' has been replaced with ceph_repository which is set to 'rhcs' in rhcs.yml.sample.

Can you please let me know how to proceed with this BZ ? Whether this is a valid bug anymore ?

Thanks,
Vasishta

Comment 11 seb 2017-09-12 15:49:10 UTC
You should see this in the rhcs.yml.sample file

egrep -v '^#|^$'  group_vars/rhcs.yml.sample
---
dummy:
fetch_directory: ~/ceph-ansible-keys
ceph_origin: repository
ceph_repository: rhcs

This should answer your question.

Comment 12 Ken Dreyer (Red Hat) 2017-09-14 16:36:56 UTC
Have all docs been changed to mention rhcs.yml.sample, instead of all.yml.sample?

Should we only remove all.yml.sample during the RPM if we are building on RHEL instead of CentOS (ie, building downstream)?

Comment 13 seb 2017-09-14 16:56:02 UTC
@Ken, yes please!

Comment 16 seb 2017-09-19 11:05:54 UTC
@ken, done.

Comment 20 Ken Dreyer (Red Hat) 2017-09-27 15:34:48 UTC
To be clear: earlier comments in this BZ indicated that docs should refer to "rhcs.yml.sample". These comments are no longer true, and it is fine for docs to refer to "all.yml.sample". The rhcs.yml.sample and all.yml.sample files now contain identical contents in the downstream ceph-ansible builds.

Comment 22 Vasishta 2017-12-01 15:02:02 UTC
Though ceph_rhcs has been removed from all.yml, corresponding variables been un-commented and set to apt value - which is serving the purpose (as mentioned in description of this bug)

Moving to VERIFIED state.

Regards,
Vasishta

Comment 25 errata-xmlrpc 2017-12-05 23:39:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:3387