Description of problem: Currently, user is required to manually uncomment and set "ceph_rhcs: true" when configuring ceph global settings. This requires an additional manual task during installation. Version-Release number of selected component (if applicable): 2.x, etc. How reproducible: As root, create an all.yml file from the all.yml.sample file, uncomment and set "ceph_rhcs: false" to "ceph_rhcs: true" Steps to Reproduce: Step 5: https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/2/html-single/installation_guide_for_red_hat_enterprise_linux/#configuring_ceph_global_settings Actual results: all.yml.sample file default value is commented out and set to "ceph_rhcs: false" Expected results: all.yml.sample file default value should be "ceph_rhcs: true" (and uncommented) to prevent user action and therefore, reduce required user tasks during installation Additional info: https://docs.google.com/document/d/14c6cx2PY6xe2XC0N9sFY8Jc-VobAy_LjpTxJsrOL_q8/edit Driven by RHCS-LT Process Improvement effort
It's tough to automate as we have Ubuntu and RHEL customers. If we had only RHEL customer I could autodetect the release and set ceph_rhcs to true and it will be easier. However I can't do that for customers using Ubuntu...
For the ceph-ansible RPM, we could have a downstream-only patch (or sed command) that flips this value. We intend to ship ceph-ansible DEBs too (bug 1436782), so we could do the same thing there.
Seems like a valid solution to me, I can also generate a rhcs.yml.sample file with the right parameters. Let me try something.
PR: here https://github.com/ceph/ceph-ansible/pull/1743
Sebastien, does this require a docs change for users to use "rhcs.yml.sample" now instead of the upstream one?
Yes, it does
Hi Sebastien, I observed that 'ceph_rhcs' has been removed from both all.yml.sample and rhcs.yml.sample Which is the corresponding variable to look for ? I though that 'ceph_rhcs' has been replaced with ceph_repository which is set to 'rhcs' in rhcs.yml.sample. Can you please let me know how to proceed with this BZ ? Whether this is a valid bug anymore ? Thanks, Vasishta
You should see this in the rhcs.yml.sample file egrep -v '^#|^$' group_vars/rhcs.yml.sample --- dummy: fetch_directory: ~/ceph-ansible-keys ceph_origin: repository ceph_repository: rhcs This should answer your question.
Have all docs been changed to mention rhcs.yml.sample, instead of all.yml.sample? Should we only remove all.yml.sample during the RPM if we are building on RHEL instead of CentOS (ie, building downstream)?
@Ken, yes please!
@ken, done.
To be clear: earlier comments in this BZ indicated that docs should refer to "rhcs.yml.sample". These comments are no longer true, and it is fine for docs to refer to "all.yml.sample". The rhcs.yml.sample and all.yml.sample files now contain identical contents in the downstream ceph-ansible builds.
Though ceph_rhcs has been removed from all.yml, corresponding variables been un-commented and set to apt value - which is serving the purpose (as mentioned in description of this bug) Moving to VERIFIED state. Regards, Vasishta
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:3387