Bug 1484711

Summary: [OSP13] rebase novnc to 1.1.0
Product: Red Hat OpenStack Reporter: Pierre-Andre MOREY <pmorey>
Component: novncAssignee: Lee Yarwood <lyarwood>
Status: CLOSED ERRATA QA Contact: Archit Modi <amodi>
Severity: high Docs Contact:
Priority: high    
Version: 10.0 (Newton)CC: amodi, ebarrera, kchamart, lyarwood, mbooth, mschuppe, pmorey, satmakur, schhabdi, sclewis, slinaber, srevivo, stephenfin
Target Milestone: z11Keywords: Rebase, Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: novnc-1.1.0-2.el7ost Doc Type: Rebase: Bug Fixes and Enhancements
Doc Text:
Story Points: ---
Clone Of: 1183025
: 1484712 1533041 1556942 1738881 (view as bug list) Environment:
Last Closed: 2020-03-10 11:24:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1183025, 1738881, 1765622, 1765626    
Bug Blocks: 1484712, 1533041, 1556942, 1556943, 1781147    

Comment 13 Stephen Finucane 2018-03-15 15:53:26 UTC
I validated a recent deployment with noVNC 1.0. It was necessary to change nova's '[vnc] novncproxy_base_url' from '{address}/vnc_auto.html' to '{address}/vnc_simple.html'. This is because of commit 83391ffc in noVNC [1]. Once that was done, everything worked as expected. However, 'vnc_simple.html' only works with noVNC 1.0 while 'vnc_auto.html' only works with 0.6.x and prior. As such, we would need to upgrade noVNC _and_ update the configuration for all hosts at the same time to avoid breaking anything. This seems unrealistic.

There are two possible options here:

- Symlink 'vnc_auto.html' to 'vnc_simple.html', thus retaining backwards compatibility.

- Start using a different url, 'vnc.html?path=websockify', which apparently works with both 0.6 and 1.0. [2]

The first of these seems a more viable option in the short term. If we proceed with this, we'll also need a migration path to ensure we don't have to carry this patch forever. This will involve updating the values in 'nova.conf' to one of the above at upgrade time.

[1] https://github.com/novnc/noVNC/commit/83391ffc38d91f6ceb5da6cf764a5411dc431543
[2] http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-03-14.log.html#t2018-03-14T14:19:07

Comment 24 Martin Schuppert 2020-01-10 12:29:23 UTC
*** Bug 1781147 has been marked as a duplicate of this bug. ***

Comment 31 errata-xmlrpc 2020-03-10 11:24:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:0754