Bug 1502931

Summary:	[RFE] Allow passing extra ansible opts to oVirt Metrics shell script
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	RFEs	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukas Svaty <lsvaty>
Severity:	medium	Docs Contact:
Priority:	low
Version:	1.0.7	CC:	bugs, lsvaty, lveyde, ylavi
Target Milestone:	ovirt-4.1.7	Keywords:	FutureFeature, Rebase, ZStream
Target Release:	1.0.7.1	Flags:	rule-engine: ovirt-4.1+ ylavi: planning_ack+ sradco: devel_ack+ lsvaty: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-metrics-1.0.7.1	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1471833	Environment:
Last Closed:	2017-11-13 12:25:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1471833
Bug Blocks:	1402901, 1468895, 1475135, 1493030

Description Shirly Radco 2017-10-17 05:36:06 UTC

+++ This bug was initially created as a clone of Bug #1471833 +++

Description of problem:
Today we run the configure_ovirt_machines_for_metrics.sh script that does a few tasks and then runs the ansible playbook with defined parameters.

We would like to embed the shell tasks in the ansible playbook and run the playbook directly.

--- Additional comment from Shirly Radco on 2017-08-13 08:09:13 EDT ---

We added an option to pass native ansible parameters.
This will allow more flexibility when running the script.

Test should verify that extra ansible parameters, like -v, are passed as expected.

--- Additional comment from Lukas Svaty on 2017-09-21 11:59:16 EDT ---

not working for playbook for hosts:

/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_hosts_for_metrics.sh -vvv

=> no verbose output

tested in ovirt-engine-metrics-1.1.1-0.0.master.20170919065728.el7.centos.noarch

--- Additional comment from Shirly Radco on 2017-09-24 08:42:46 EDT ---

This should work for Please run:
/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machine_for_metrics.sh -vvv

--- Additional comment from Lukas Svaty on 2017-09-25 04:19:48 EDT ---

(In reply to Shirly Radco from comment #3)
> This should work for Please run:
> /usr/share/ovirt-engine-metrics/setup/ansible/
> configure_ovirt_machine_for_metrics.sh -vvv

The patch is still on POST. Please note comment#2 where it was verified for configure_ovirt_machine_for_metrics.sh however failing for configure_ovirt_hosts_for_metrics.sh that is fixed in Didis patch. 

Please do not move bugs to ON_QA before patches are merged or QA has proper builds.

--- Additional comment from Shirly Radco on 2017-09-25 05:19:53 EDT ---

Since /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_hosts_for_metrics.sh only add --scope=hosts, I'll remove this script so we will only have one ansible script to configure oVirt metrics.

--- Additional comment from Lukas Svaty on 2017-10-04 11:23:53 EDT ---

verified in ovirt-engine-metrics-1.1.1-0.0.master.20171001113530.el7.centos.noarch

Comment 1 Lukas Svaty 2017-10-19 15:36:45 UTC

[root@ ~]# /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh -v
FATAL: Invalid option '-v'
[root@ ~]# rpm -qa | grep metrics
ovirt-engine-metrics-1.0.7-1.el7ev.noarch

patch did not get through

Comment 2 Sandro Bonazzola 2017-10-21 06:14:12 UTC

Lukas, note this has been fixed in 1.0.7.1 not 1.0.7-1

Comment 3 Lukas Svaty 2017-10-25 10:15:46 UTC

verified in ovirt-engine-metrics-1.0.7.1-1.el7ev.noarch