Bug 1506903

Summary:	Event webhook should work with HTTPS urls
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	eventsapi	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	mainline	CC:	amukherj, rhs-bugs, sabose, sanandpa, sasundar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1466122
Clones:	1509200 (view as bug list)		Environment:
Last Closed:	2017-12-08 17:45:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1466122
Bug Blocks:	1509200

Description Aravinda VK 2017-10-27 06:44:36 UTC

+++ This bug was initially created as a clone of Bug #1466122 +++

Description of problem:

While integrating gluster with oVirt, an HTTPS url was used to register the webhook with gluster-events.

The webhook test fails with error:
NOT OK: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:579)



Version-Release number of selected component (if applicable):


How reproducible:
Always

Comment 1 Worker Ant 2017-10-27 06:56:08 UTC

REVIEW: https://review.gluster.org/18578 (eventsapi: HTTPS support for Webhooks) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 2 Worker Ant 2017-10-30 11:07:17 UTC

REVIEW: https://review.gluster.org/18578 (eventsapi: HTTPS support for Webhooks) posted (#1) for review on master by Aravinda VK

Comment 3 Worker Ant 2017-10-31 06:47:35 UTC

COMMIT: https://review.gluster.org/18578 committed in master by  

------------- eventsapi: HTTPS support for Webhooks

First it tries to call URL with verify=True without specifying the cert
path, it succeeds if a webhook is HTTP or HTTPS with CA trusted
certificates(for example https://github..).

If above call fails with SSL error then it tries to get the server
certificate and calls URL again. If call fails with SSL error even after
using the certificate, then verification will be disabled and logged in
the log file.

All other errors will be catched and logged as usual.

BUG: 1506903
Change-Id: I86a3390ed48b75dffdc7848022af23a1e1d7f076
Signed-off-by: Aravinda VK <avishwan>

Comment 4 Shyamsundar 2017-12-08 17:45:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/