Bug 1509200 - Event webhook should work with HTTPS urls
Summary: Event webhook should work with HTTPS urls
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: eventsapi
Version: 3.12
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: Aravinda VK
QA Contact:
URL:
Whiteboard:
Depends On: 1466122 1506903
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-03 10:36 UTC by Aravinda VK
Modified: 2017-11-29 05:53 UTC (History)
5 users (show)

Fixed In Version: glusterfs-glusterfs-3.12.3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1506903
Environment:
Last Closed: 2017-11-29 05:53:24 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Aravinda VK 2017-11-03 10:36:59 UTC
+++ This bug was initially created as a clone of Bug #1506903 +++

+++ This bug was initially created as a clone of Bug #1466122 +++

Description of problem:

While integrating gluster with oVirt, an HTTPS url was used to register the webhook with gluster-events.

The webhook test fails with error:
NOT OK: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:579)



Version-Release number of selected component (if applicable):


How reproducible:
Always

--- Additional comment from Worker Ant on 2017-10-27 02:56:08 EDT ---

REVIEW: https://review.gluster.org/18578 (eventsapi: HTTPS support for Webhooks) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2017-10-30 07:07:17 EDT ---

REVIEW: https://review.gluster.org/18578 (eventsapi: HTTPS support for Webhooks) posted (#1) for review on master by Aravinda VK

--- Additional comment from Worker Ant on 2017-10-31 02:47:35 EDT ---

COMMIT: https://review.gluster.org/18578 committed in master by  

------------- eventsapi: HTTPS support for Webhooks

First it tries to call URL with verify=True without specifying the cert
path, it succeeds if a webhook is HTTP or HTTPS with CA trusted
certificates(for example https://github..).

If above call fails with SSL error then it tries to get the server
certificate and calls URL again. If call fails with SSL error even after
using the certificate, then verification will be disabled and logged in
the log file.

All other errors will be catched and logged as usual.

BUG: 1506903
Change-Id: I86a3390ed48b75dffdc7848022af23a1e1d7f076
Signed-off-by: Aravinda VK <avishwan>

Comment 1 Worker Ant 2017-11-03 10:38:42 UTC
REVIEW: https://review.gluster.org/18651 (eventsapi: HTTPS support for Webhooks) posted (#1) for review on release-3.12 by Aravinda VK

Comment 2 Worker Ant 2017-11-09 09:16:31 UTC
COMMIT: https://review.gluster.org/18651 committed in release-3.12 by  

------------- eventsapi: HTTPS support for Webhooks

First it tries to call URL with verify=True without specifying the cert
path, it succeeds if a webhook is HTTP or HTTPS with CA trusted
certificates(for example https://github..).

If above call fails with SSL error then it tries to get the server
certificate and calls URL again. If call fails with SSL error even after
using the certificate, then verification will be disabled and logged in
the log file.

All other errors will be catched and logged as usual.

BUG: 1509200
Change-Id: I86a3390ed48b75dffdc7848022af23a1e1d7f076
Signed-off-by: Aravinda VK <avishwan>
(cherry picked from commit 4216869c724cf19c12d63c0580de88e9427e6467)

Comment 3 Jiffin 2017-11-29 05:53:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.3, please open a new bug report.

glusterfs-glusterfs-3.12.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-devel/2017-November/053983.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.