Bug 1516204

Summary: docker-puppet.py failure are being ignored
Product: Red Hat OpenStack Reporter: Michele Baldessari <michele>
Component: openstack-tripleo-heat-templatesAssignee: Michele Baldessari <michele>
Status: CLOSED ERRATA QA Contact: Artem Hrechanychenko <ahrechan>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 12.0 (Pike)CC: jschluet, m.andre, mburns, mcornea, rhel-osp-director-maint, sclewis, tvignaud
Target Milestone: rcKeywords: Triaged
Target Release: 12.0 (Pike)   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-7.0.3-12.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-13 22:22:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michele Baldessari 2017-11-22 09:30:16 UTC 
Description of problem:
Via https://bugzilla.redhat.com/show_bug.cgi?id=1501852 we fixed a bunch of issues around puppet errors being ignored by the higher level parts of the stack. As it turns out there are other invocations where we ignore the errors reported. Namely in ansible playbooks like this:
- name: return code
  shell: |
    echo "fail 2"
    exit 2
  failed_when: false
  log_when: false
  register: outputs
- debug: msg="Broken (does not fail as expected)"
  when: outputs is defined
  failed_when: outputs|failed

The problem with the above playbooks is that 'failed_when: false' makes it so
that the 'failed' key in the outputs dictionary is set to false and so we do not ever fail correctly. The other problem is that 'outputs is defined' is always true even when the previous task was skipped.
Comment 3 Jon Schlueter 2017-11-22 17:38:44 UTC 
openstack-tripleo-heat-templates-7.0.3-12.el7ost
Comment 6 Artem Hrechanychenko 2017-12-05 07:48:24 UTC 
VERIFIED

verified as part of controller replacement procedure https://bugzilla.redhat.com/show_bug.cgi?id=1494455
Comment 9 errata-xmlrpc 2017-12-13 22:22:16 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462