Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1516204 - docker-puppet.py failure are being ignored
docker-puppet.py failure are being ignored
Status: CLOSED ERRATA
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-heat-templates (Show other bugs)
12.0 (Pike)
All Linux
urgent Severity urgent
: rc
: 12.0 (Pike)
Assigned To: Michele Baldessari
Artem Hrechanychenko
: Triaged
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-22 04:30 EST by Michele Baldessari
Modified: 2018-02-05 14:18 EST (History)
8 users (show)

See Also:
Fixed In Version: openstack-tripleo-heat-templates-7.0.3-12.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-12-13 17:22:16 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Launchpad 1733402 None None None 2017-11-22 04:34 EST
OpenStack gerrit 521828 None None None 2017-11-22 04:34 EST
Red Hat Product Errata RHEA-2017:3462 normal SHIPPED_LIVE Red Hat OpenStack Platform 12.0 Enhancement Advisory 2018-02-15 20:43:25 EST

  None (edit)
Description Michele Baldessari 2017-11-22 04:30:16 EST
Description of problem:
Via https://bugzilla.redhat.com/show_bug.cgi?id=1501852 we fixed a bunch of issues around puppet errors being ignored by the higher level parts of the stack. As it turns out there are other invocations where we ignore the errors reported. Namely in ansible playbooks like this:
- name: return code
  shell: |
    echo "fail 2"
    exit 2
  failed_when: false
  log_when: false
  register: outputs
- debug: msg="Broken (does not fail as expected)"
  when: outputs is defined
  failed_when: outputs|failed

The problem with the above playbooks is that 'failed_when: false' makes it so
that the 'failed' key in the outputs dictionary is set to false and so we do not ever fail correctly. The other problem is that 'outputs is defined' is always true even when the previous task was skipped.
Comment 3 Jon Schlueter 2017-11-22 12:38:44 EST
openstack-tripleo-heat-templates-7.0.3-12.el7ost
Comment 6 Artem Hrechanychenko 2017-12-05 02:48:24 EST
VERIFIED

verified as part of controller replacement procedure https://bugzilla.redhat.com/show_bug.cgi?id=1494455
Comment 9 errata-xmlrpc 2017-12-13 17:22:16 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462

Note You need to log in before you can comment on or make changes to this bug.