Bug 1540538

Summary:	sd_journal can "leak" fds if it starts dropping inotify events
Product:	Red Hat Enterprise Linux 7	Reporter:	Lukáš Nykrýn <lnykryn>
Component:	systemd	Assignee:	systemd-maint
Status:	CLOSED ERRATA	QA Contact:	Frantisek Sumsal <fsumsal>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	7.5	CC:	bbreard, bleanhar, fsumsal, msekleta, pportant, rmeggins, systemd-maint-list, systemd-maint
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	systemd-219-57.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1547373 (view as bug list)		Environment:
Last Closed:	2018-04-10 11:25:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1547373

Description Lukáš Nykrýn 2018-01-31 10:53:41 UTC

sd_journal keeps open fds for every journal files. Those are closed only in the case when journal file is deleted (presumably due to rotation), and we get an inotify event. Unfortunately, this process is not reliable.

We need to check if we haven't dropped any inotify messages and in such case re-iterate through the journal files on the disk again.

This issue is present in upstream as well.

Comment 3 Lukáš Nykrýn 2018-02-14 14:06:33 UTC

*** Bug 1545146 has been marked as a duplicate of this bug. ***

Comment 6 Lukáš Nykrýn 2018-02-19 08:50:04 UTC

Just to update the bug. Right now we are still working on the patch that should fix all corner cases.

https://github.com/systemd/systemd/pull/8204

Comment 7 Lukáš Nykrýn 2018-02-20 15:40:14 UTC

fix merged to staging branch -> https://github.com/lnykryn/systemd-rhel/pull/196 -> post

Comment 13 errata-xmlrpc 2018-04-10 11:25:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0711