Bug 1547373 – sd_journal can "leak" fds if it starts dropping inotify events [rhel-7.4.z]

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1547373 - sd_journal can "leak" fds if it starts dropping inotify events [rhel-7.4.z] [NEEDINFO]

Summary:	sd_journal can "leak" fds if it starts dropping inotify events [rhel-7.4.z]

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	systemd (Show other bugs)
Sub Component:
Version:	7.5
Hardware:	Unspecified Unspecified

Priority	urgent Severity urgent
Target Milestone:	rc
Target Release:	---
Assigned To:	systemd-maint
QA Contact:	Frantisek Sumsal
Docs Contact:	Marie Dolezelova

URL:
Whiteboard:
Keywords:	ZStream

Depends On:	1540538
Blocks:
	Show dependency tree / graph

Reported:	2018-02-21 02:49 EST by Oneata Mircea Teodor
Modified:	2018-03-06 16:50 EST (History)
CC List:	10 users (show)

See Also:
Fixed In Version:	systemd-219-42.el7_4.10
Doc Type:	Bug Fix
Doc Text:	If journald rotated the log files quickly enough, and the application which was using the sd_journal API did not read messages fast enough, the API sometimes started losing messages about deleted files. Consequently, the sd_journal API did not close file descriptors for such files, and they were never removed from the disk. To fix this problem, the sd_journal API now reiterates through files, finds those that were removed, and closes their file descriptors, if it detects the loss of messages about deleted files. As a result, the kernel is now able to delete the files completely from the disk.
Story Points:	---
Clone Of:	1540538
Environment:
Last Closed:	2018-03-06 16:50:34 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	pportant: needinfo? (mdolezel)

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0416	normal	SHIPPED_LIVE	systemd bug fix update	2018-03-06 21:46:04 EST

Groups: None (edit)

Description Oneata Mircea Teodor 2018-02-21 02:49:23 EST

This bug has been copied from bug #1540538 and has been proposed to be backported to 7.4 z-stream (EUS).

Comment 5 Peter Portante 2018-03-01 11:11:41 EST

Can you consider this revised text for the "Doc Text"?

If journald rotates the internal log files quickly enough, and an application
using the sd_journal API did not read messages fast enough, the API could start
losing notifications about deleted internal log files.  Consequently, the
sd_journal API would not know to close file descriptors for such files,
preventing them from being removed from the disk by the kernel.

To fix this problem, the sd_journal API now re-iterates through internal log
files, finds those that were removed and closes their file descriptors, allowing
the kernel to remove the files completely from the disk.

Comment 7 errata-xmlrpc 2018-03-06 16:50:34 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0416

Note You need to log in before you can comment on or make changes to this bug.