Bug 1540538 – sd_journal can "leak" fds if it starts dropping inotify events

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1540538 - sd_journal can "leak" fds if it starts dropping inotify events

Summary:	sd_journal can "leak" fds if it starts dropping inotify events

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	systemd (Show other bugs)
Sub Component:
Version:	7.5
Hardware:	Unspecified Unspecified

Priority	urgent Severity urgent
Target Milestone:	rc
Target Release:	---
Assigned To:	systemd-maint
QA Contact:	Frantisek Sumsal
Docs Contact:

URL:
Whiteboard:
Keywords:	ZStream

Duplicates:	1545146 (view as bug list)
Depends On:
Blocks:	1547373
	Show dependency tree / graph

Reported:	2018-01-31 05:53 EST by Lukáš Nykrýn
Modified:	2018-04-10 07:26 EDT (History)
CC List:	8 users (show)

See Also:
Fixed In Version:	systemd-219-57.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Clones:	1547373 (view as bug list)
Environment:
Last Closed:	2018-04-10 07:25:34 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0711	None	None	None	2018-04-10 07:26 EDT

Groups: None (edit)

Description Lukáš Nykrýn 2018-01-31 05:53:41 EST

sd_journal keeps open fds for every journal files. Those are closed only in the case when journal file is deleted (presumably due to rotation), and we get an inotify event. Unfortunately, this process is not reliable.

We need to check if we haven't dropped any inotify messages and in such case re-iterate through the journal files on the disk again.

This issue is present in upstream as well.

Comment 3 Lukáš Nykrýn 2018-02-14 09:06:33 EST

*** Bug 1545146 has been marked as a duplicate of this bug. ***

Comment 6 Lukáš Nykrýn 2018-02-19 03:50:04 EST

Just to update the bug. Right now we are still working on the patch that should fix all corner cases.

https://github.com/systemd/systemd/pull/8204

Comment 7 Lukáš Nykrýn 2018-02-20 10:40:14 EST

fix merged to staging branch -> https://github.com/lnykryn/systemd-rhel/pull/196 -> post

Comment 13 errata-xmlrpc 2018-04-10 07:25:34 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0711

Note You need to log in before you can comment on or make changes to this bug.