Bug 1540819
Summary: | Failed to unbind after deleting templateinstance with servicebinding existing | |||
---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | XiuJuan Wang <xiuwang> | |
Component: | Service Broker | Assignee: | Ben Parees <bparees> | |
Status: | CLOSED ERRATA | QA Contact: | XiuJuan Wang <xiuwang> | |
Severity: | low | Docs Contact: | ||
Priority: | medium | |||
Version: | 3.9.0 | CC: | aos-bugs, bjarolim, bleanhar, bparees, chezhang, erjones, jmatthew, jminter, openshift-bugs-escalate, pmorie, prsharma, sakulkar, vlaad | |
Target Milestone: | --- | |||
Target Release: | 3.9.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
Cause: Unbinding a template service instance throws an error if the template service instance was deleted.
Consequence: It becomes impossible to unbind a service instance if the template service instance was manually deleted, including if the project containing the TSI was deleted.
Fix: The template service broker will return success/gone in cases where the unbind refers to a non-existent template service instance.
Result: The unbind can proceed even if the TSI no longer exists.
|
Story Points: | --- | |
Clone Of: | ||||
: | 1543039 1543044 (view as bug list) | Environment: | ||
Last Closed: | 2018-06-27 18:01:32 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1543039, 1543044 |
Description
XiuJuan Wang
2018-02-01 05:25:12 UTC
I don't foresee us prompting the user to prevent them from deleting a templateinstance that has bindings (though if we did, that would be a web console thing, so maybe an RFE should be opened against it. you'd still always be able to just "oc delete" it though and we're never going to prevent that). As for the behavior of the TSB's unbind operation, when the template instance in question no longer exists, I suspect the TSB is "working as designed" here, but I defer to Paul Morie if he thinks the TSB should return some other response on the unbind request. Jim Minter may have some insight as to the expected/intended/agreed upon behavior also, so adding him to the CC. Marking low severity as you have to semi-intentionally get yourself in this situation. (I think we're hitting this codepath: https://github.com/openshift/origin/blob/ddd1f926d749c914e479b2c54e385137a99873c2/pkg/templateservicebroker/servicebroker/unbind.go#L48 it's possible we should explicitly check for IsNotFound(err) on the templateinstance lookup and just return a StatusGone message if we get one, will double check w/ Jim when he gets back, or if Paul has insight) *** Bug 1535171 has been marked as a duplicate of this bug. *** Commit pushed to master at https://github.com/openshift/origin https://github.com/openshift/origin/commit/495739248a10c95768b0a743ad0e7fcf34ef04db Merge pull request #18416 from bparees/tsb_binding Automatic merge from submit-queue. return gone on unbind from non-existent templateinstance bug 1540819 https://bugzilla.redhat.com/show_bug.cgi?id=1540819 *** Bug 1538370 has been marked as a duplicate of this bug. *** The fix has merged into ocp v3.9.0-0.42.0. And can't reproduce this bug. Please help set to on_qa when you are free As comment #9, move this bug to verified Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:2013 |